refactor: clean up workers.js — remove dead code, extract Config.applyRunConfig

- Remove dead code: activeWorkers Map, maxWorkers, empty recorder placeholder
- Simplify _initializeTestPool to 4 lines
- Remove redundant configWithoutFunctions variable in WorkerObject.addConfig
- Remove hardcoded mochawesome/mocha-junit-reporter path manipulation from
  createWorkerObjects — fragile, incomplete, and redundant with output dir override
- Extract getOverridenConfig to Config.applyRunConfig() in lib/config.js,
  shared by both workers.js and run-multiple.js

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: DavertMik

lib/command/run-multiple.js

@@ -9,6 +9,7 @@ import { createRuns } from './run-multiple/collection.js'
 import { clearString, replaceValueDeep } from '../utils.js'
 import { getConfig, getTestRoot, fail } from './utils.js'
 import store from '../store.js'
+import Config from '../config.js'
 
 const __filename = fileURLToPath(import.meta.url)
 const __dirname = path.dirname(__filename)
@@ -115,17 +116,11 @@ export default async function (selectedRuns, options) {
 }
 
 function executeRun(runName, runConfig) {
-  // clone config
-  let overriddenConfig = { ...config }
+  let overriddenConfig = Config.applyRunConfig(config, runConfig)
 
-  // get configuration
   const browserConfig = runConfig.browser
   const browserName = browserConfig.browser
 
-  for (const key in browserConfig) {
-    overriddenConfig.helpers = replaceValueDeep(overriddenConfig.helpers, key, browserConfig[key])
-  }
-
   let outputDir = `${runName}_`
   if (browserConfig.outputName) {
     outputDir += typeof browserConfig.outputName === 'function' ? browserConfig.outputName() : browserConfig.outputName
@@ -138,20 +133,10 @@ function executeRun(runName, runConfig) {
 
   outputDir = clearString(outputDir)
 
-  // tweaking default output directories and for mochawesome
   overriddenConfig = replaceValueDeep(overriddenConfig, 'output', path.join(config.output, outputDir))
   overriddenConfig = replaceValueDeep(overriddenConfig, 'reportDir', path.join(config.output, outputDir))
   overriddenConfig = replaceValueDeep(overriddenConfig, 'mochaFile', path.join(config.output, outputDir, `${browserName}_report.xml`))
 
-  // override tests configuration
-  if (overriddenConfig.tests) {
-    overriddenConfig.tests = runConfig.tests
-  }
-
-  if (overriddenConfig.gherkin && runConfig.gherkin && runConfig.gherkin.features) {
-    overriddenConfig.gherkin.features = runConfig.gherkin.features
-  }
-
   // override grep param and collect all params
   const params = ['run', '--child', `${runId++}.${runName}:${browserName}`, '--override', JSON.stringify(overriddenConfig)]
 

lib/config.js

@@ -1,7 +1,7 @@
 import fs from 'fs'
 import path from 'path'
 import { createRequire } from 'module'
-import { fileExists, isFile, deepMerge, deepClone } from './utils.js'
+import { fileExists, isFile, deepMerge, deepClone, replaceValueDeep } from './utils.js'
 import { transpileTypeScript, cleanupTempFiles, fixErrorStack } from './utils/typescript.js'
 
 const defaultConfig = {
@@ -134,6 +134,33 @@ class Config {
     return (config = deepMerge(config, additionalConfig))
   }
 
+  /**
+   * Apply run configuration (browser overrides, tests, gherkin) to a base config.
+   * Used by workers and run-multiple to create per-run configurations.
+   *
+   * @param {Object} baseConfig
+   * @param {Object} runConfig - must have .browser object, optionally .tests and .gherkin
+   * @return {Object}
+   */
+  static applyRunConfig(baseConfig, runConfig) {
+    const overriddenConfig = deepClone(baseConfig)
+    const browserConfig = runConfig.browser
+
+    for (const key in browserConfig) {
+      overriddenConfig.helpers = replaceValueDeep(overriddenConfig.helpers, key, browserConfig[key])
+    }
+
+    if (overriddenConfig.tests && runConfig.tests) {
+      overriddenConfig.tests = runConfig.tests
+    }
+
+    if (overriddenConfig.gherkin && runConfig.gherkin?.features) {
+      overriddenConfig.gherkin.features = runConfig.gherkin.features
+    }
+
+    return overriddenConfig
+  }
+
   /**
    * Resets config to default
    * @return {Object<string, *>}

lib/workers.js

@@ -13,7 +13,7 @@ import Codecept from './codecept.js'
 import MochaFactory from './mocha/factory.js'
 import Container from './container.js'
 import { getTestRoot } from './command/utils.js'
-import { isFunction, fileExists, replaceValueDeep, deepClone } from './utils.js'
+import { isFunction, fileExists } from './utils.js'
 import mainConfig from './config.js'
 import output from './output.js'
 import event from './event.js'
@@ -117,34 +117,11 @@ const createWorkerObjects = (testGroups, config, testRoot, options, selectedRuns
   }
   const workersToExecute = []
 
-  const currentOutputFolder = config.output
-  let currentMochawesomeReportDir
-  let currentMochaJunitReporterFile
-
-  if (config.mocha && config.mocha.reporterOptions) {
-    currentMochawesomeReportDir = config.mocha.reporterOptions?.mochawesome.options.reportDir
-    currentMochaJunitReporterFile = config.mocha.reporterOptions['mocha-junit-reporter'].options.mochaFile
-  }
-
   createRuns(selectedRuns, config).forEach(worker => {
-    const separator = path.sep
-    const _config = { ...config }
-    let workerName = worker.name.replace(':', '_')
-    _config.output = `${currentOutputFolder}${separator}${workerName}`
-    if (config.mocha && config.mocha.reporterOptions) {
-      _config.mocha.reporterOptions.mochawesome.options.reportDir = `${currentMochawesomeReportDir}${separator}${workerName}`
-
-      const _tempArray = currentMochaJunitReporterFile.split(separator)
-      _tempArray.splice(
-        _tempArray.findIndex(item => item.includes('.xml')),
-        0,
-        workerName,
-      )
-      _config.mocha.reporterOptions['mocha-junit-reporter'].options.mochaFile = _tempArray.join(separator)
-    }
-    workerName = worker.getOriginalName() || worker.getName()
-    const workerConfig = worker.getConfig()
-    workersToExecute.push(getOverridenConfig(workerName, workerConfig, _config))
+    const workerName = worker.name.replace(':', '_')
+    const _config = mainConfig.applyRunConfig(config, worker.getConfig())
+    _config.output = path.join(config.output, workerName)
+    workersToExecute.push(_config)
   })
   const workers = []
   let index = 0
@@ -188,27 +165,6 @@ const convertToMochaTests = testGroup => {
   return group
 }
 
-const getOverridenConfig = (workerName, workerConfig, config) => {
-  // clone config
-  const overriddenConfig = deepClone(config)
-
-  // get configuration
-  const browserConfig = workerConfig.browser
-
-  for (const key in browserConfig) {
-    overriddenConfig.helpers = replaceValueDeep(overriddenConfig.helpers, key, browserConfig[key])
-  }
-
-  // override tests configuration
-  if (overriddenConfig.tests) {
-    overriddenConfig.tests = workerConfig.tests
-  }
-
-  if (overriddenConfig.gherkin && workerConfig.gherkin && workerConfig.gherkin.features) {
-    overriddenConfig.gherkin.features = workerConfig.gherkin.features
-  }
-  return overriddenConfig
-}
 
 class WorkerObject {
   /**
@@ -224,17 +180,11 @@ class WorkerObject {
   addConfig(config) {
     const oldConfig = JSON.parse(this.options.override || '{}')
 
-    // Remove customLocatorStrategies from both old and new config before JSON serialization
-    // since functions cannot be serialized and will be lost, causing workers to have empty strategies.
-    // Note: Only WebDriver helper supports customLocatorStrategies
-    const configWithoutFunctions = { ...config }
-
-    // Clean both old and new config
     const cleanConfig = cfg => {
       if (cfg.helpers) {
         cfg.helpers = { ...cfg.helpers }
         Object.keys(cfg.helpers).forEach(helperName => {
-          if (cfg.helpers[helperName] && cfg.helpers[helperName].customLocatorStrategies !== undefined) {
+          if (cfg.helpers[helperName]?.customLocatorStrategies !== undefined) {
             cfg.helpers[helperName] = { ...cfg.helpers[helperName] }
             delete cfg.helpers[helperName].customLocatorStrategies
           }
@@ -243,11 +193,7 @@ class WorkerObject {
       return cfg
     }
 
-    const cleanedOldConfig = cleanConfig(oldConfig)
-    const cleanedNewConfig = cleanConfig(configWithoutFunctions)
-
-    // Deep merge configurations to preserve all helpers from base config
-    const newConfig = merge({}, cleanedOldConfig, cleanedNewConfig)
+    const newConfig = merge({}, cleanConfig(oldConfig), cleanConfig(config))
     this.options.override = JSON.stringify(newConfig)
   }
 
@@ -292,8 +238,6 @@ class Workers extends EventEmitter {
     this.testPool = []
     this.testPoolInitialized = false
     this.isPoolMode = config.by === 'pool'
-    this.activeWorkers = new Map()
-    this.maxWorkers = numberOfWorkers // Track original worker count for pool mode
 
     createOutputDir(config.testConfig)
     // Defer worker initialization until codecept is ready
@@ -395,36 +339,11 @@ class Workers extends EventEmitter {
     this.testGroups = populateGroups(numberOfWorkers)
   }
 
-  /**
-   * Initialize the test pool if not already done
-   * This is called lazily to avoid state pollution issues during construction
-   */
   _initializeTestPool() {
-    if (this.testPoolInitialized) {
-      return
-    }
-
-    // Ensure codecept is initialized
-    if (!this.codecept) {
-      output.log('Warning: codecept not initialized when initializing test pool')
-      this.testPoolInitialized = true
-      return
-    }
-
-    const files = this.codecept.testFiles
-    if (!files || files.length === 0) {
-      this.testPoolInitialized = true
-      return
-    }
-
-    // In ESM, test UIDs are not stable across different mocha instances
-    // So instead of using UIDs, we distribute test FILES
-    // Each file may contain multiple tests
-    for (const file of files) {
-      this.testPool.push(file)
-    }
-
+    if (this.testPoolInitialized) return
     this.testPoolInitialized = true
+    if (!this.codecept) return
+    this.testPool = [...this.codecept.testFiles]
   }
 
   /**
@@ -493,10 +412,6 @@ class Workers extends EventEmitter {
       workerThreads.push(workerThread)
     }
 
-    recorder.add('workers started', () => {
-      // Workers are already running, this is just a placeholder step
-    })
-
     // Add overall timeout to prevent infinite hanging
     const overallTimeout = setTimeout(() => {
       console.error('[Main] Overall timeout reached (10 minutes). Force terminating remaining workers...')
@@ -533,11 +448,6 @@ class Workers extends EventEmitter {
   }
 
   _listenWorkerEvents(worker) {
-    // Track worker thread for pool mode
-    if (this.isPoolMode) {
-      this.activeWorkers.set(worker, { available: true, workerIndex: null })
-    }
-    
     // Track last activity time to detect hanging workers
     let lastActivity = Date.now()
     let currentTest = null