Skip to content

Commit 647597d

Browse files
committed
Made review changes
1 parent 8b1441f commit 647597d

File tree

3 files changed

+13
-8
lines changed

3 files changed

+13
-8
lines changed

scripts/3-report/gcs_report.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@
3030
QUARTER = os.path.basename(PATHS["data_quarter"])
3131
SECTION_FILE = Path(__file__).name
3232
SECTION_TITLE = "Google Custom Search (GCS)"
33-
LAST_ENTRY = shared.path_join(PATHS["data_phase"], "gcs_free_culture.png")
3433

3534

3635
def parse_arguments():
@@ -69,8 +68,9 @@ def parse_arguments():
6968
if not args.enable_save and args.enable_git:
7069
parser.error("--enable-git requires --enable-save")
7170
if args.quarter != QUARTER:
72-
global PATHS
71+
global PATHS, QUARTER
7372
PATHS = shared.paths_update(LOGGER, PATHS, QUARTER, args.quarter)
73+
QUARTER = args.quarter
7474
args.logger = LOGGER
7575
args.paths = PATHS
7676
return args
@@ -497,6 +497,7 @@ def main():
497497
args = parse_arguments()
498498
shared.paths_log(LOGGER, PATHS)
499499
shared.git_fetch_and_merge(args, PATHS["repo"])
500+
LAST_ENTRY = shared.path_join(PATHS["data_phase"], "gcs_free_culture.png")
500501
shared.check_completion_file_exists(args, LAST_ENTRY)
501502
gcs_intro(args)
502503
plot_products(args)

scripts/3-report/github_report.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@
2828
QUARTER = os.path.basename(PATHS["data_quarter"])
2929
SECTION_FILE = Path(__file__).name
3030
SECTION_TITLE = "Github"
31-
LAST_ENTRY = shared.path_join(PATHS["data_phase"], "github_restriction.png")
3231

3332

3433
def parse_arguments():
@@ -72,8 +71,9 @@ def parse_arguments():
7271
if not args.enable_save and args.enable_git:
7372
parser.error("--enable-git requires --enable-save")
7473
if args.quarter != QUARTER:
75-
global PATHS
74+
global PATHS, QUARTER
7675
PATHS = shared.paths_update(LOGGER, PATHS, QUARTER, args.quarter)
76+
QUARTER = args.quarter
7777
args.logger = LOGGER
7878
args.paths = PATHS
7979
return args
@@ -249,6 +249,9 @@ def main():
249249
args = parse_arguments()
250250
shared.paths_log(LOGGER, PATHS)
251251
shared.git_fetch_and_merge(args, PATHS["repo"])
252+
LAST_ENTRY = shared.path_join(
253+
PATHS["data_phase"], "github_restriction.png"
254+
)
252255
shared.check_completion_file_exists(args, LAST_ENTRY)
253256
github_intro(args)
254257
plot_totals_by_license_type(args)

scripts/3-report/wikipedia_report.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,9 +28,6 @@
2828
QUARTER = os.path.basename(PATHS["data_quarter"])
2929
SECTION_FILE = Path(__file__).name
3030
SECTION_TITLE = "Wikipedia"
31-
LAST_ENTRY = shared.path_join(
32-
PATHS["data_phase"], "wikipedia_least_language_usage.png"
33-
)
3431

3532

3633
def parse_arguments():
@@ -69,8 +66,9 @@ def parse_arguments():
6966
if not args.enable_save and args.enable_git:
7067
parser.error("--enable-git requires --enable-save")
7168
if args.quarter != QUARTER:
72-
global PATHS
69+
global PATHS, QUARTER
7370
PATHS = shared.paths_update(LOGGER, PATHS, QUARTER, args.quarter)
71+
QUARTER = args.quarter
7472
args.logger = LOGGER
7573
args.paths = PATHS
7674
return args
@@ -269,6 +267,9 @@ def main():
269267
args = parse_arguments()
270268
shared.paths_log(LOGGER, PATHS)
271269
shared.git_fetch_and_merge(args, PATHS["repo"])
270+
LAST_ENTRY = shared.path_join(
271+
PATHS["data_phase"], "wikipedia_least_language_usage.png"
272+
)
272273
shared.check_completion_file_exists(args, LAST_ENTRY)
273274
wikipedia_intro(args)
274275
plot_language_representation(args)

0 commit comments

Comments
 (0)