Skip to content

Commit b2ad661

Browse files
committed
Made review changes
1 parent 8a470e4 commit b2ad661

File tree

2 files changed

+6
-17
lines changed

2 files changed

+6
-17
lines changed

scripts/3-report/github_report.py

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -29,11 +29,6 @@
2929
SECTION_FILE = Path(__file__).name
3030
SECTION_TITLE = "Github"
3131

32-
IMAGE_PATHS = [
33-
shared.path_join(PATHS["data_phase"], "github_totals_by_license_type.png"),
34-
shared.path_join(PATHS["data_phase"], "github_restriction.png"),
35-
]
36-
3732

3833
def parse_arguments():
3934
"""
@@ -78,14 +73,6 @@ def parse_arguments():
7873
return args
7974

8075

81-
def check_image_files(args, image_paths):
82-
for path in image_paths:
83-
if os.path.exists(path) and not args.force:
84-
raise shared.QuantifyingException(
85-
f"image file already exists for {path}", 0
86-
)
87-
88-
8976
def load_data(args):
9077
"""
9178
Load the collected data from the CSV file.
@@ -256,7 +243,6 @@ def main():
256243
args = parse_arguments()
257244
shared.paths_log(LOGGER, PATHS)
258245
shared.git_fetch_and_merge(args, PATHS["repo"])
259-
check_image_files(args, IMAGE_PATHS)
260246
github_intro(args)
261247
plot_totals_by_license_type(args)
262248
plot_totals_by_restriction(args)

scripts/3-report/zzz-notes.py

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,8 @@
2626

2727
# Constants
2828
QUARTER = os.path.basename(PATHS["data_quarter"])
29-
SECTION = Path(__file__).name
29+
SECTION_FILE = Path(__file__).name
30+
SECTION_TITLE = "Notes"
3031

3132

3233
def parse_arguments():
@@ -73,7 +74,8 @@ def data_locations(args):
7374
"""
7475
shared.update_readme(
7576
args,
76-
SECTION,
77+
SECTION_FILE,
78+
SECTION_TITLE,
7779
"Data locations",
7880
None,
7981
None,
@@ -101,7 +103,8 @@ def usage(args):
101103
"""
102104
shared.update_readme(
103105
args,
104-
SECTION,
106+
SECTION_FILE,
107+
SECTION_TITLE,
105108
"Usage",
106109
None,
107110
None,

0 commit comments

Comments
 (0)