Skip to content

Commit fafa17f

Browse files
committed
use new shared.rows_to_csv function
1 parent fa4801a commit fafa17f

File tree

1 file changed

+3
-25
lines changed

1 file changed

+3
-25
lines changed

scripts/1-fetch/museums_victoria_fetch.py

Lines changed: 3 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55

66
# Standard library
77
import argparse
8-
import csv
98
import os
109
import re
1110
import sys
@@ -80,24 +79,6 @@ def parse_arguments():
8079
return args
8180

8281

83-
def initialize_data_file(file_path, header):
84-
with open(file_path, "w", encoding="utf-8", newline="\n") as file_obj:
85-
writer = csv.DictWriter(file_obj, fieldnames=header, dialect="unix")
86-
writer.writeheader()
87-
88-
89-
def initialize_all_data_files(args):
90-
if not args.enable_save:
91-
return
92-
93-
# Create data directory for this phase
94-
os.makedirs(PATHS["data_phase"], exist_ok=True)
95-
96-
initialize_data_file(FILE1_COUNT, HEADER1_COUNT)
97-
initialize_data_file(FILE2_MEDIA, HEADER2_MEDIA)
98-
initialize_data_file(FILE3_RECORD, HEADER3_RECORD)
99-
100-
10182
def write_counts_to_csv(args, data: dict):
10283
if not args.enable_save:
10384
return
@@ -135,11 +116,7 @@ def write_counts_to_csv(args, data: dict):
135116
}
136117
for row in data[1].items()
137118
]
138-
with open(file_path, "a", encoding="utf-8", newline="\n") as file_obj:
139-
writer = csv.DictWriter(
140-
file_obj, fieldnames=fieldnames, dialect="unix"
141-
)
142-
writer.writerows(rows)
119+
shared.rows_to_csv(args, file_path, fieldnames, rows)
143120

144121

145122
def fetch_museums_victoria_data(args, session):
@@ -188,6 +165,8 @@ def fetch_museums_victoria_data(args, session):
188165
media_list = res.get("media", [])
189166
for media_item in media_list:
190167
license_data = media_item.get("license")
168+
if not license_data:
169+
continue
191170

192171
# Counting the unique license types
193172
license_short_name = license_data.get("shortName")
@@ -243,7 +222,6 @@ def main():
243222
args = parse_arguments()
244223
shared.paths_log(LOGGER, PATHS)
245224
shared.git_fetch_and_merge(args, PATHS["repo"])
246-
initialize_all_data_files(args)
247225
data = fetch_museums_victoria_data(args, shared.get_session())
248226
write_counts_to_csv(args, data)
249227
args = shared.git_add_and_commit(

0 commit comments

Comments
 (0)