Skip to content

Commit 3ae0fa4

Browse files
committed
Make sure to get the output from all benchmarks before failing
1 parent fd491d5 commit 3ae0fa4

1 file changed

Lines changed: 6 additions & 2 deletions

File tree

test/systemTests/benchmarkRunner.ts

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,22 +66,26 @@ class PerformanceBenchmark {
6666
private checkPerformanceRegression(): void {
6767
console.log(`\n📊 Comparing against hard-coded baseline`);
6868

69+
let hasRegression = false;
70+
6971
// Factory creation comparison
70-
let hasRegression = this.comparePerformance(
72+
const factoryRegression = this.comparePerformance(
7173
'Factory creation',
7274
this.results.factoryCreation.average,
7375
this.baseline.factoryCreation.average,
7476
6
7577
);
78+
hasRegression = hasRegression || factoryRegression;
7679

7780
// Document formatting comparisons
7881
for (const [size, results] of Object.entries(this.results.documentFormatting)) {
7982
if (this.baseline.documentFormatting[size]) {
80-
hasRegression = hasRegression || this.comparePerformance(
83+
const documentRegression = this.comparePerformance(
8184
`Document formatting (${size})`,
8285
results.average,
8386
this.baseline.documentFormatting[size].average
8487
);
88+
hasRegression = hasRegression || documentRegression;
8589
}
8690
}
8791

0 commit comments

Comments
 (0)