Allow tabs to be used as table indentation without left border

Author: darkriszty

README.md

@@ -17,7 +17,7 @@ Makes tables more readable for humans. Compatible with the Markdown writer plugi
 - Support column alignment options with ":".
 - Find and format multiple tables.
 - Support \``code blocks`\` and ignore blocks with `<!-- markdown-table-prettify-ignore-start -->` and `<!-- markdown-table-prettify-ignore-end -->`.
-- Support indented tables.
+- Support indented tables (tables with borders or tab indented).
 
 ## Visual Studio Code
 

src/modelFactory/transformers/borderTransformer.ts

@@ -14,7 +14,8 @@ export class BorderTransformer extends Transformer {
         const rows: Row[] = this.rowsWithoutEmptyFirstAndLastColumn(input.rows, hasLeftBorder, hasRightBorder);
         const alignments = this.alignmentsWithoutEmptyFirstAndLastColumn(input.alignments, hasLeftBorder, hasRightBorder);
 
-        const leftPad = hasLeftBorder 
+        // allow indentation if the table has a clear left border or if it was indented with tabs (possibly with additional spaces for alignment)
+        const leftPad = hasLeftBorder || /^\t/.test(input.leftPad)
             ? input.leftPad
             : "";
         let result = new Table(rows, input.separatorEOL, alignments, leftPad);

test/systemTests/resources/indentWithoutBordersButUsingTabs-expected.md

@@ -0,0 +1,48 @@
+* Single tab
+	Type  | Range            | Size
+	------|------------------|-------------------------
+	sbyte | -128 to 127      | Signed 8-bit integer
+	byte  | 0 to 255         | Unsigned 8-bit integer
+	char  | U+0000 to U+ffff | Unicode 16-bit character
+* Two tabs
+		Type  | Range            | Size
+		------|------------------|-------------------------
+		sbyte | -128 to 127      | Signed 8-bit integer
+		byte  | 0 to 255         | Unsigned 8-bit integer
+		char  | U+0000 to U+ffff | Unicode 16-bit character
+* Mixed tabs and spaces, but more tab
+	Type  | Range            | Size
+	------|------------------|-------------------------
+	sbyte | -128 to 127      | Signed 8-bit integer
+	byte  | 0 to 255         | Unsigned 8-bit integer
+	char  | U+0000 to U+ffff | Unicode 16-bit character
+* Left aligned
+	Type  | Range            | Size
+	:-----|:-----------------|:------------------------
+	sbyte | -128 to 127      | Signed 8-bit integer
+	byte  | 0 to 255         | Unsigned 8-bit integer
+	char  | U+0000 to U+ffff | Unicode 16-bit character
+* Right aligned
+	 Type |            Range |                     Size
+	-----:|-----------------:|------------------------:
+	sbyte |      -128 to 127 |     Signed 8-bit integer
+	 byte |         0 to 255 |   Unsigned 8-bit integer
+	 char | U+0000 to U+ffff | Unicode 16-bit character
+* Center aligned
+	 Type | Range            |           Size
+	:----:|:-----------------|:-----------------------:
+	sbyte | -128 to 127      |   Signed 8-bit integer
+	 byte | 0 to 255         |  Unsigned 8-bit integer
+	 char | U+0000 to U+ffff | Unicode 16-bit character
+* Already right aligned should remain untouched
+	 Type |            Range |                     Size
+	-----:|-----------------:|------------------------:
+	sbyte |      -128 to 127 |     Signed 8-bit integer
+	 byte |         0 to 255 |   Unsigned 8-bit integer
+	 char | U+0000 to U+ffff | Unicode 16-bit character
+* Already center aligned should remain untouched
+	 Type | Range            |           Size
+	:----:|:-----------------|:-----------------------:
+	sbyte | -128 to 127      |   Signed 8-bit integer
+	 byte | 0 to 255         |  Unsigned 8-bit integer
+	 char | U+0000 to U+ffff | Unicode 16-bit character

test/systemTests/resources/indentWithoutBordersButUsingTabs-input.md

@@ -0,0 +1,48 @@
+* Single tab
+	Type | Range|	Size
+	-|-|-
+	sbyte |	-128 to 127|	Signed 8-bit integer
+	byte|	0 to 255|	Unsigned 8-bit integer
+	char|	U+0000 to U+ffff|	Unicode 16-bit character
+* Two tabs
+		Type | Range|	Size
+		-|-|-
+		sbyte |	-128 to 127|	Signed 8-bit integer
+		byte|	0 to 255|	Unsigned 8-bit integer
+		char|	U+0000 to U+ffff|	Unicode 16-bit character
+* Mixed tabs and spaces, but more tab
+	Type | Range|	Size
+	-|-|-
+    sbyte |	-128 to 127|	Signed 8-bit integer
+    byte|	0 to 255|	Unsigned 8-bit integer
+	char|	U+0000 to U+ffff|	Unicode 16-bit character
+* Left aligned
+	Type | Range|	Size
+	:-|:-|:-
+	sbyte |	-128 to 127|	Signed 8-bit integer
+	byte|	0 to 255|	Unsigned 8-bit integer
+	char|	U+0000 to U+ffff|	Unicode 16-bit character
+* Right aligned
+	Type | Range|	Size
+	-:|-:|-:
+	sbyte |	-128 to 127|	Signed 8-bit integer
+	byte|	0 to 255|	Unsigned 8-bit integer
+	char|	U+0000 to U+ffff|	Unicode 16-bit character
+* Center aligned
+	Type | Range|	Size
+	:-:|:-|:-:
+	sbyte |	-128 to 127|	Signed 8-bit integer
+	byte|	0 to 255|	Unsigned 8-bit integer
+	char|	U+0000 to U+ffff|	Unicode 16-bit character
+* Already right aligned should remain untouched
+	 Type |            Range |                     Size
+	-----:|-----------------:|------------------------:
+	sbyte |      -128 to 127 |     Signed 8-bit integer
+	 byte |         0 to 255 |   Unsigned 8-bit integer
+	 char | U+0000 to U+ffff | Unicode 16-bit character
+* Already center aligned should remain untouched
+	 Type | Range            |           Size
+	:----:|:-----------------|:-----------------------:
+	sbyte | -128 to 127      |   Signed 8-bit integer
+	 byte | 0 to 255         |  Unsigned 8-bit integer
+	 char | U+0000 to U+ffff | Unicode 16-bit character

test/unitTests/modelFactory/transformers/borderTransformer.test.ts

@@ -66,13 +66,43 @@ suite("BorderTransformer tests", () => {
         assert.strictEqual(table.leftPad, "\t");
     });
 
-    test("process() does not keep leftPad if table has no left border", () => {
+    test("process() does not keep leftPad if table has no left border and uses spaces", () => {
+        const rows = [
+            ["  h1  ", " ", "  h3  "],
+            ["c", "  ", "e"]
+        ];
+        const table = createSut().process(tableFor(rows, "    "));
+
+        assert.strictEqual(table.leftPad, "");
+    });
+
+    test("process() keeps leftPad if table has no left border but uses tabs", () => {
         const rows = [
             ["  h1  ", " ", "  h3  "],
             ["c", "  ", "e"]
         ];
         const table = createSut().process(tableFor(rows, "\t"));
 
+        assert.strictEqual(table.leftPad, "\t");
+    });
+
+    test("process() keeps leftPad if table has no left border but uses multiple tabs", () => {
+        const rows = [
+            ["  h1  ", " ", "  h3  "],
+            ["c", "  ", "e"]
+        ];
+        const table = createSut().process(tableFor(rows, "\t\t\t"));
+
+        assert.strictEqual(table.leftPad, "\t\t\t");
+    });
+
+    test("process() does not keep leftPad if table has no left border and uses mixed whitespace", () => {
+        const rows = [
+            ["  h1  ", " ", "  h3  "],
+            ["c", "  ", "e"]
+        ];
+        const table = createSut().process(tableFor(rows, " \t "));
+
         assert.strictEqual(table.leftPad, "");
     });