Enable noImplicitAny in TypeScript config

- Remove noImplicitAny: false from tsconfig.json and tsconfig.dist.json
- Add explicit type annotations to cli/inputReader.ts and cli/index.ts
- Add type annotation to tableFinder.ts nextRangeResult variable
- Fix vscode.Range and vscode.Position constructor calls in test stubs
- Extract BenchmarkBaselineEntry interface in benchmarkRunner.ts
- Add explicit types to test variables in test files

Author: darkriszty

cli/index.ts

@@ -7,7 +7,7 @@ import { InputReader } from "./inputReader";
 
 const cliOptions: CliOptions = parseArguments(process.argv);
 
-InputReader.subscribe(input =>
+InputReader.subscribe((input: string) =>
     cliOptions.check
         ? CliPrettify.check(input, cliOptions)
         : process.stdout.write(CliPrettify.prettify(input, cliOptions))

cli/inputReader.ts

@@ -1,5 +1,5 @@
 export class InputReader {
-    static subscribe(readDone): void {
+    static subscribe(readDone: (input: string) => void): void {
         if (process.stdin.isTTY) {
             readDone(process.argv[2] || "");
         } else {

src/tableFinding/tableFinder.ts

@@ -24,7 +24,7 @@ export class TableFinder {
 
             if (!isInIgnoreBlock) {
                 const isValidSeparatorRow = this._tableValidator.lineIsValidSeparator(document.lines[rowIndex].value);
-                const nextRangeResult = isValidSeparatorRow
+                const nextRangeResult: { range: Range, ignoreBlockStarted: boolean } = isValidSeparatorRow
                     ? this.getNextValidTableRange(document, rowIndex)
                     : { range: null, ignoreBlockStarted: isInIgnoreBlock};
 

test/stubs/markdownTextDocumentStub.ts

@@ -81,13 +81,13 @@ export class MarkdownTextDocumentStub implements vscode.TextDocument {
         return 0;
     }
     getWordRangeAtPosition(position: vscode.Position): vscode.Range {
-        return new vscode.Range[0];
+        return new vscode.Range(0, 0, 0, 0);
     }
     validateRange(range: vscode.Range): vscode.Range {
         return range;
     }
     positionAt(offset: number): vscode.Position {
-        return new vscode.Position[0];
+        return new vscode.Position(0, 0);
     }
     validatePosition(position: vscode.Position): vscode.Position {
         return position;

test/systemTests/benchmarkRunner.ts

@@ -4,6 +4,12 @@ import * as vscode from 'vscode';
 import { getDistinctTestFileNames } from './systemTestFileReader';
 import { getDocumentPrettyfier } from '../../src/extension/prettyfierFactory';
 
+interface BenchmarkBaselineEntry {
+    average: number;
+    median: number;
+    standardDeviation: number;
+}
+
 interface BenchmarkResults {
     factoryCreation: {
         iterations: number;
@@ -39,7 +45,7 @@ class PerformanceBenchmark {
     private testFiles: { name: string; size: 'small' | 'medium' | 'large' }[] = [];
     private overallStartTime: bigint = BigInt(0);
 
-    private readonly baseline = {
+    private readonly baseline: { factoryCreation: BenchmarkBaselineEntry, documentFormatting: Record<string, BenchmarkBaselineEntry> } = {
         factoryCreation: { average: 0.0001675, median: 0.0001522, standardDeviation: 0.0001 },
         documentFormatting: {
             small: { average: 0.1429, median: 0.1162, standardDeviation: 0.05 },
@@ -415,14 +421,14 @@ class PerformanceBenchmark {
             ...this.results,
             factoryCreation: {
                 ...this.results.factoryCreation,
-                times: undefined // Exclude times array
+                times: undefined as undefined // Exclude times array
             },
             documentFormatting: Object.fromEntries(
                 Object.entries(this.results.documentFormatting).map(([size, data]) => [
                     size,
                     {
                         ...data,
-                        times: undefined // Exclude times arrays
+                        times: undefined as undefined // Exclude times arrays
                     }
                 ])
             )

test/unitTests/extension/tableDocumentRangePrettyfier.test.ts

@@ -30,7 +30,7 @@ suite("TableDocumentRangePrettyfier tests", () => {
     test("provideDocumentRangeFormattingEdits() invalid table selection doesn't alter the selected text", () => {
         const sut = createSut();
         const input = Array(5).fill("hello world").join("\n");
-        const expectedResult = null;
+        const expectedResult: string = null;
         const document = new MarkdownTextDocumentStub(input);
         const range = document.getFullRange();
         _multiTablePrettyfier.setup(_ => _.formatTables(It.isAny())).returns(() => expectedResult);

test/unitTests/modelFactory/alignmentFactory.test.ts

@@ -5,7 +5,7 @@ import { Alignment } from "../../../src/models/alignment";
 suite("AlignmentFactory tests", () => {
 
     test("createAlignments() with null throws error", () => {
-        const separatorCells = null;
+        const separatorCells: string[] = null;
         const sut = createFactory();
 
         assert.throws(() => sut.createAlignments(separatorCells))

tsconfig.dist.json

@@ -8,7 +8,6 @@
         "sourceMap": false,
         "rootDir": ".",
         "strictNullChecks": false,
-        "noImplicitAny": false,
         "strictPropertyInitialization": false
     },
     "include": [

tsconfig.json

@@ -8,7 +8,6 @@
         "sourceMap": true,
         "rootDir": ".",
         "strictNullChecks": false,
-        "noImplicitAny": false,
         "strictPropertyInitialization": false
     },
     "exclude": [ "node_modules", ".vscode-test" ]