Commit 8611c72
authored
fix: enable TestWorkflowJob functional test that was unreachable on all profiles (#1401)
## Summary
- Fix `TestWorkflowJob` functional test that was **never actually
running** due to three compounding bugs:
1. `skip_profile` listed all 3 available profiles (`databricks_cluster`,
`databricks_uc_sql_endpoint`, `databricks_uc_cluster`) — test was
skipped everywhere
2. Used `simple_python_model` which hardcodes
`submission_method='serverless_cluster'` in `dbt.config()`, overriding
the YAML's `workflow_job` setting — test was exercising the wrong code
path
3. `workflow_schema` included `max_retries` which is not a valid
`jobs.create()` parameter
resolves follow-up to #1360
### changes
- Add `workflow_python_model` fixture without `submission_method` in
`dbt.config()` so the YAML schema's `submission_method: workflow_job`
takes effect
- Remove `databricks_uc_cluster` from skip list so the test runs on at
least one profile
- Remove invalid `max_retries` from `workflow_schema`
### checklist
- [x] i have run this code in development and it appears to resolve the
stated issue
- [x] this pr includes tests, or tests are not required/relevant for
this pr
- [x] i have updated the `CHANGELOG.md` and added information about my
change to the "dbt-databricks next" section.
## Test plan
- [x] Verified test was SKIPPED on all 3 profiles before the fix
- [x] Verified test PASSES on `databricks_uc_cluster` profile after the
fix (ran against live cluster)1 parent 5927a32 commit 8611c72
File tree
3 files changed
+14
-5
lines changed- tests/functional/adapter/python_model
3 files changed
+14
-5
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
| 10 | + | |
10 | 11 | | |
11 | 12 | | |
12 | 13 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
102 | 102 | | |
103 | 103 | | |
104 | 104 | | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
105 | 116 | | |
106 | 117 | | |
107 | 118 | | |
| |||
110 | 121 | | |
111 | 122 | | |
112 | 123 | | |
113 | | - | |
114 | 124 | | |
115 | 125 | | |
116 | 126 | | |
| |||
Lines changed: 2 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
259 | 259 | | |
260 | 260 | | |
261 | 261 | | |
262 | | - | |
263 | | - | |
264 | | - | |
| 262 | + | |
265 | 263 | | |
266 | 264 | | |
267 | 265 | | |
268 | 266 | | |
269 | 267 | | |
270 | | - | |
| 268 | + | |
271 | 269 | | |
272 | 270 | | |
273 | 271 | | |
| |||
0 commit comments