Commit 8a3671f
Rawk Akani
fix(ext/node): remove kUseNativeWrap on TLS TCP handles to fix HTTPS regression
The native wrap path introduced in #33184 sets `kUseNativeWrap = true` on
freshly created TCP handles in `TLSSocket._wrapHandle`. This forces the
handle into `#nativeConnect` which never populates `kStreamBaseField`.
When `http.ts:_writeHeader` later reads
`handle[kStreamBaseField][internalRidSymbol]` to obtain the connection
rid for `op_node_http_request_with_conn`, it crashes:
TypeError: Cannot read properties of undefined
(reading 'Symbol(Deno.internal.rid)')
This breaks all HTTPS client requests via Node compat (Playwright,
@deno/sandbox, any npm package using https.request).
Regression bisected:
- 2.7.11: works
- 2.7.12: broken
Fix: remove the `kUseNativeWrap = true` assignment so freshly created
TCP handles use the legacy connect path that populates `kStreamBaseField`
with a `TcpConn` carrying a valid rid.
Fixes #33231
Fixes #332291 parent e99152e commit 8a3671f
1 file changed
+0
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
315 | 315 | | |
316 | 316 | | |
317 | 317 | | |
318 | | - | |
319 | 318 | | |
320 | 319 | | |
321 | 320 | | |
| |||
0 commit comments