Skip to content

Commit 9c277ea

Browse files
authored
Update to CSV 0.9 (#7)
* Update to CSV 0.9 * Remove hardcoded Int64 * Fix tests * Actually fix tests
1 parent 2493109 commit 9c277ea

File tree

2 files changed

+16
-18
lines changed

2 files changed

+16
-18
lines changed

Project.toml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,14 @@
11
name = "PalmerPenguins"
22
uuid = "8b842266-38fa-440a-9b57-31493939ab85"
3-
authors = ["David Widmann <dev+git@devmotion.de>"]
4-
version = "0.1.2"
3+
authors = ["David Widmann <david.widmann@it.uu.se>"]
4+
version = "0.1.3"
55

66
[deps]
77
CSV = "336ed68f-0bac-5ca0-87d4-7b16caf5d00b"
88
DataDeps = "124859b0-ceae-595e-8997-d05f6a7a8dfe"
99

1010
[compat]
11-
CSV = "0.7.1, 0.8"
11+
CSV = "0.7.1, 0.8, 0.9"
1212
DataDeps = "0.7.2"
1313
julia = "1"
1414

test/runtests.jl

Lines changed: 13 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -25,13 +25,11 @@ ENV["DATADEPS_ALWAYS_ACCEPT"] = true
2525
String,
2626
Union{Missing,Float64},
2727
Union{Missing,Float64},
28-
Union{Missing,Int64},
29-
Union{Missing,Int64},
28+
Union{Missing,Int},
29+
Union{Missing,Int},
3030
Union{Missing,String},
3131
]
32-
firstrow_simplified = [
33-
"Adelie", "Torgersen", 39.1, 18.7, Int64(181), Int64(3750), "male"
34-
]
32+
firstrow_simplified = ["Adelie", "Torgersen", 39.1, 18.7, 181, 3750, "male"]
3533

3634
colnames_raw = [
3735
"studyName",
@@ -54,7 +52,7 @@ ENV["DATADEPS_ALWAYS_ACCEPT"] = true
5452
]
5553
coleltypes_raw = [
5654
String,
57-
Int64,
55+
Int,
5856
String,
5957
String,
6058
String,
@@ -63,16 +61,16 @@ ENV["DATADEPS_ALWAYS_ACCEPT"] = true
6361
Date,
6462
Union{Missing,Float64},
6563
Union{Missing,Float64},
66-
Union{Missing,Int64},
67-
Union{Missing,Int64},
64+
Union{Missing,Int},
65+
Union{Missing,Int},
6866
Union{Missing,String},
6967
Float64,
7068
Float64,
7169
String,
7270
]
7371
firstrow_raw = [
7472
"PAL0708",
75-
Int64(1),
73+
1,
7674
"Adelie Penguin (Pygoscelis adeliae)",
7775
"Anvers",
7876
"Torgersen",
@@ -82,8 +80,8 @@ ENV["DATADEPS_ALWAYS_ACCEPT"] = true
8280
Date(2007, 11, 11),
8381
39.1,
8482
18.7,
85-
Int64(181),
86-
Int64(3750),
83+
181,
84+
3750,
8785
"MALE",
8886
missing,
8987
missing,
@@ -109,7 +107,7 @@ ENV["DATADEPS_ALWAYS_ACCEPT"] = true
109107
# Check first row
110108
firstrow = first(table)
111109
for i in 1:length(firstrow)
112-
@test firstrow[i] === firstrow_simplified[i]
110+
@test isequal(firstrow[i], firstrow_simplified[i])
113111
end
114112
end
115113

@@ -127,7 +125,7 @@ ENV["DATADEPS_ALWAYS_ACCEPT"] = true
127125
# Check first row
128126
firstrow = first(table)
129127
for i in 1:length(firstrow)
130-
@test firstrow[i] === firstrow_raw[i]
128+
@test isequal(firstrow[i], firstrow_raw[i])
131129
end
132130
end
133131
end
@@ -151,7 +149,7 @@ ENV["DATADEPS_ALWAYS_ACCEPT"] = true
151149
# Check first row
152150
firstrow = df[1, :]
153151
for i in 1:length(firstrow)
154-
@test firstrow[i] === firstrow_simplified[i]
152+
@test isequal(firstrow[i], firstrow_simplified[i])
155153
end
156154
end
157155

@@ -169,7 +167,7 @@ ENV["DATADEPS_ALWAYS_ACCEPT"] = true
169167
# Check first row
170168
firstrow = df[1, :]
171169
for i in 1:length(firstrow)
172-
@test firstrow[i] === firstrow_raw[i]
170+
@test isequal(firstrow[i], firstrow_raw[i])
173171
end
174172
end
175173
end

0 commit comments

Comments
 (0)