Skip to content

Commit 32e6ee7

Browse files
committed
add dolt_ proc check on no overloads CALL statement
1 parent b40e171 commit 32e6ee7

1 file changed

Lines changed: 6 additions & 2 deletions

File tree

server/node/call.go

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,8 @@
1515
package node
1616

1717
import (
18+
"strings"
19+
1820
"github.com/cockroachdb/errors"
1921
"github.com/dolthub/go-mysql-server/sql"
2022
"github.com/dolthub/go-mysql-server/sql/plan"
@@ -99,8 +101,10 @@ func (c *Call) RowIter(ctx *sql.Context, r sql.Row) (sql.RowIter, error) {
99101
return nil, err
100102
}
101103
if len(overloads) == 0 {
102-
// We're going to assume that this is calling one of the few remaining Dolt stored procedures
103-
return nil, functions.ErrDoltProcedureSelectOnly
104+
if strings.HasPrefix(c.ProcedureName, "dolt_") {
105+
return nil, functions.ErrDoltProcedureSelectOnly
106+
}
107+
return nil, sql.ErrStoredProcedureDoesNotExist.New(c.ProcedureName)
104108
}
105109

106110
overloadTree := framework.NewOverloads()

0 commit comments

Comments
 (0)