Skip to content

Commit 3ccd886

Browse files
committed
fixed tests
1 parent 3815061 commit 3ccd886

1 file changed

Lines changed: 3 additions & 5 deletions

File tree

testing/go/types_test.go

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,6 @@ var typesTests = []ScriptTest{
8888
{
8989
Query: "SELECT * FROM t_bit ORDER BY id;",
9090
Expected: []sql.Row{
91-
// TODO: the pg library is interpreting the bit string `101` as `a0` (right-padded with zeroes) instead of `05`, not sure if that's correct or not
9291
{1, pgtype.Bits{Bytes: []uint8{0xda}, Len: 8, Valid: true}, pgtype.Bits{Bytes: []uint8{0xa0}, Len: 3, Valid: true}},
9392
{2, pgtype.Bits{Bytes: []uint8{0x2b}, Len: 8, Valid: true}, pgtype.Bits{Bytes: []uint8{0x0}, Len: 3, Valid: true}},
9493
},
@@ -117,7 +116,6 @@ var typesTests = []ScriptTest{
117116
},
118117
{
119118
Name: "Bit key",
120-
Skip: true, // no comparator in serialization layer
121119
SetUpScript: []string{
122120
"CREATE TABLE t_bit (id BIT(8) primary key, v1 BIT(8));",
123121
"INSERT INTO t_bit VALUES (B'11011010', B'11011010'), (B'00101011', B'00101011');",
@@ -126,7 +124,7 @@ var typesTests = []ScriptTest{
126124
{
127125
Query: "SELECT * FROM t_bit WHERE id = B'11011010' ORDER BY id;",
128126
Expected: []sql.Row{
129-
{[]byte{0xDA}, []byte{0xDA}},
127+
{pgtype.Bits{Bytes: []uint8{0xda}, Len: 8, Valid: true}, pgtype.Bits{Bytes: []uint8{0xda}, Len: 8, Valid: true}},
130128
},
131129
},
132130
},
@@ -3095,8 +3093,8 @@ var typesTests = []ScriptTest{
30953093
"create table t_uuid2 (id int primary key, v1 uuid, v2 uuid);",
30963094
"create index on t_uuid2(v1, v2);",
30973095
"insert into t_uuid2 values " +
3098-
"(1, 'f47ac10b58cc4372a567-0e02b2c3d479', 'a0eebc99-9c0b-4ef8-bb6d-6bb9bd380a11'), " +
3099-
"(2, 'dcf783c8-49c2-44b4-8b90-34ad8c52ea1e', 'f99802e8-0018-4913-806c-bcad5d246d46');",
3096+
"(1, 'f47ac10b58cc4372a567-0e02b2c3d479', 'a0eebc99-9c0b-4ef8-bb6d-6bb9bd380a11'), " +
3097+
"(2, 'dcf783c8-49c2-44b4-8b90-34ad8c52ea1e', 'f99802e8-0018-4913-806c-bcad5d246d46');",
31003098
},
31013099
Assertions: []ScriptTestAssertion{
31023100
{

0 commit comments

Comments
 (0)