working test

Author: zachmu

server/functions/bit.go

@@ -66,8 +66,8 @@ var bitout = framework.Function1{
 	Parameters: [1]*pgtypes.DoltgresType{pgtypes.Bit},
 	Strict:     true,
 	Callable: func(ctx *sql.Context, t [2]*pgtypes.DoltgresType, val any) (any, error) {
-		bitStr := val.(tree.DBitArray)
-		return bitStr.String(), nil
+		bitStr := val.(*tree.DBitArray)
+		return tree.AsStringWithFlags(bitStr, tree.FmtPgwireText), nil
 	},
 }
 
@@ -94,8 +94,11 @@ var bitsend = framework.Function1{
 	Parameters: [1]*pgtypes.DoltgresType{pgtypes.Bit},
 	Strict:     true,
 	Callable: func(ctx *sql.Context, _ [2]*pgtypes.DoltgresType, val any) (any, error) {
-		bitStr := val.(tree.DBitArray)
-		return bitStr.String(), nil
+		bitStr := val.(*tree.DBitArray)
+		str := tree.AsStringWithFlags(bitStr, tree.FmtPgwireText)
+		wr := utils.NewWriter(uint64(4 + len(str)))
+		wr.String(str)
+		return wr.Data(), nil
 	},
 }
 

testing/go/types_test.go

@@ -18,6 +18,7 @@ import (
 	"testing"
 
 	"github.com/dolthub/go-mysql-server/sql"
+	"github.com/jackc/pgx/v5/pgtype"
 )
 
 func TestTypes(t *testing.T) {
@@ -88,8 +89,8 @@ var typesTests = []ScriptTest{
 			{
 				Query: "SELECT * FROM t_bit ORDER BY id;",
 				Expected: []sql.Row{
-					{1, []byte{0xDA}},
-					{2, []byte{0x2B}},
+					{1, pgtype.Bits{Bytes: []uint8{0xda}, Len: 8, Valid: true}},
+					{2, pgtype.Bits{Bytes: []uint8{0x2b}, Len: 8, Valid: true}},
 				},
 			},
 		},
@@ -3008,8 +3009,8 @@ var typesTests = []ScriptTest{
 			"create table t_uuid2 (id int primary key, v1 uuid, v2 uuid);",
 			"create index on t_uuid2(v1, v2);",
 			"insert into t_uuid2 values " +
-				"(1, 'f47ac10b58cc4372a567-0e02b2c3d479', 'a0eebc99-9c0b-4ef8-bb6d-6bb9bd380a11'), " +
-				"(2, 'dcf783c8-49c2-44b4-8b90-34ad8c52ea1e', 'f99802e8-0018-4913-806c-bcad5d246d46');",
+					"(1, 'f47ac10b58cc4372a567-0e02b2c3d479', 'a0eebc99-9c0b-4ef8-bb6d-6bb9bd380a11'), " +
+					"(2, 'dcf783c8-49c2-44b4-8b90-34ad8c52ea1e', 'f99802e8-0018-4913-806c-bcad5d246d46');",
 		},
 		Assertions: []ScriptTestAssertion{
 			{