[no-release-notes] testing/go/binding_test.go: Fix a race condition in our Listener GetRunningServer() usage beacuse these tests were not waiting for services stop before they finished.

Not waiting meant that the test running could go on and start another test while the previous server was still tearing down.

Author: reltuk

testing/go/binding_test.go

@@ -28,7 +28,11 @@ import (
 func TestBindingWithOidZero(t *testing.T) {
 	// Start up a test server
 	ctx, connection, controller := CreateServer(t, "postgres")
-	defer controller.Stop()
+	defer func() {
+		connection.Close(ctx)
+		controller.Stop()
+		require.NoError(t, controller.WaitForStop())
+	}()
 	conn := connection.Default
 
 	// Create a table to insert into
@@ -51,7 +55,11 @@ func TestBindingWithOidZero(t *testing.T) {
 
 func TestBindingWithTextArray(t *testing.T) {
 	ctx, connection, controller := CreateServer(t, "postgres")
-	defer controller.Stop()
+	defer func() {
+		connection.Close(ctx)
+		controller.Stop()
+		require.NoError(t, controller.WaitForStop())
+	}()
 	conn := connection.Default
 
 	m := pgtype.NewMap()