better err msg

Author: Nathan Gabrielson

server/connection_data.go

@@ -230,7 +230,7 @@ func checkCompatibleTypes(existingOid, newOid uint32, newName string) error {
 	existing := pgtypes.GetTypeByID(id.Type(id.Cache().ToInternal(existingOid)))
 	newType := pgtypes.GetTypeByID(id.Type(id.Cache().ToInternal(newOid)))
 	if _, _, err = framework.FindCommonType([]*pgtypes.DoltgresType{existing, newType}); err != nil {
-		err = errors.Errorf("double placeholder given for %s", newName)
+		err = errors.Errorf("parameter %s is used for incompatible types: %s and %s", newName, existing.String(), newType.String())
 	}
 	return err
 }

testing/go/prepared_statement_test.go

@@ -1343,12 +1343,7 @@ var preparedStatementTests = []ScriptTest{
 			{
 				Query:       "SELECT * FROM text_test where fullname = $1 and id = $1",
 				BindVars:    []any{1},
-				ExpectedErr: "double placeholder given for v1",
-			},
-			{
-				Query:       "SELECT * FROM text_test where fullname = $1 and id = $1",
-				BindVars:    []any{"foo"},
-				ExpectedErr: "double placeholder given for v1",
+				ExpectedErr: "parameter v1 is used for incompatible types: text and integer",
 			},
 		},
 	},