docs(analyzer): shorten TODO comments

Refs: #1648

Author: codeaucafe

server/analyzer/resolve_values_types.go

@@ -131,31 +131,10 @@ func ResolveValuesTypes(ctx *sql.Context, a *analyzer.Analyzer, node sql.Node, s
 			for _, child := range n.Children() {
 				childSchema = append(childSchema, child.Schema()...)
 			}
-			// TODO: resolve GMS case asymmetry issues.
-			// GMS has a casing asymmetry for aggregate names that forces
-			// case-insensitive matching here. GMS's Builder.buildAggregateFunc()
-			// in planbuilder/aggregates.go lowercases the entire aggregate
-			// name producing "sum(v.n)", but GroupBy.Schema() in
-			// plan/group_by.go keeps original casing from e.String()
-			// producing "SUM(v.n)". Without strings.ToLower, the match
-			// fails silently and aggregate type propagation breaks, causing
-			// runtime panics (interface conversion: interface {} is
-			// decimal.Decimal, not int32).
-			//
-			// We can't use non-name matching because sql.Column has no
-			// ColumnId field, so there is nothing on the child schema side
-			// to match against GetField.Id(). Name is the only shared
-			// identifier.
-			//
-			// This causes a known false-match when two quoted column names
-			// differ only by case (e.g., "Val" vs "val"), since the
-			// planbuilder has already lowered both to the same GetField
-			// name. GMS originated as a MySQL engine where identifiers are
-			// case-insensitive, but Postgres requires case-sensitivity for
-			// quoted identifiers. A proper fix requires structured
-			// case-sensitivity discrimination in GMS, either by adding
-			// ColumnId to sql.Column or by fixing the casing asymmetry in
-			// Builder.buildAggregateFunc() and GroupBy.Schema().
+			// TODO: GMS is case-insensitive for identifiers, so aggregate
+			// GetField names and child schema names may differ in casing.
+			// We use strings.ToLower to handle this, but Postgres requires
+			// case-sensitivity for quoted identifiers, which this breaks.
 			gfName := strings.ToLower(gf.Name())
 			for _, col := range childSchema {
 				if strings.ToLower(col.Name) == gfName && gf.Type() != col.Type {

testing/go/values_statement_test.go

@@ -558,14 +558,10 @@ var ValuesStatementTests = []ScriptTest{
 		Name: "VALUES with case-differing quoted columns and aggregates",
 		Assertions: []ScriptTestAssertion{
 			{
-				// TODO: resolve GMS case asymmetry issues.
-				// Builder.buildAggregateFunc() in planbuilder/aggregates.go
-				// lowercases entire aggregate names, so SUM("Val") and
-				// SUM("val") both become "sum(v.val)" in the GetField. The
-				// second pass in ResolveValuesTypes must use strings.ToLower
-				// to match against GroupBy.Schema() which keeps original
-				// casing. This causes a false match when two columns differ
-				// only by case. See resolve_values_types.go for details.
+				// TODO: GMS is case-insensitive for identifiers, but
+				// Postgres requires case-sensitivity for quoted identifiers.
+				// Columns "Val" and "val" both become "val" after
+				// strings.ToLower, so their aggregates match the wrong column.
 				Skip:  true,
 				Query: `SELECT SUM("Val"), SUM("val") FROM (VALUES(1, 10),(2.5, 20)) v("Val", "val");`,
 				Expected: []sql.Row{