Skip to content

Commit f9d8827

Browse files
committed
fix(tests): unskip dolt_clean zero-argument tests
Issue #1361 reported that SELECT DOLT_CLEAN() with no arguments failed with "function dolt_clean() does not exist". This was fixed in PR #1763 which added Function0 registration for all Dolt procedures, but the corresponding tests in dolt_functions_test.go remained skipped. Note: PR #1373 (referenced by issue #1361) also added skipped tests in prepared_statement_test.go, but those were already unskipped in commit 62569c7 ("finished removing custom expr type"). List of changes below: - Remove Skip: true from zero-argument DOLT_CLEAN() tests - Reorder test assertions so DOLT_CLEAN('t1') runs before DOLT_CLEAN() - Add table recreation step between test cases to verify both work Refs: #1361
1 parent 7078359 commit f9d8827

1 file changed

Lines changed: 10 additions & 5 deletions

File tree

testing/go/dolt_functions_test.go

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2746,12 +2746,19 @@ func TestDoltFunctionSmokeTests(t *testing.T) {
27462746
},
27472747
},
27482748
{
2749-
Skip: true, // TODO: function dolt_clean() does not exist
2750-
Query: "SELECT DOLT_CLEAN();",
2749+
Query: "SELECT DOLT_CLEAN('t1');",
27512750
Expected: []sql.Row{{"{0}"}},
27522751
},
27532752
{
2754-
Query: "SELECT DOLT_CLEAN('t1');",
2753+
Query: "SELECT * FROM dolt.status;",
2754+
Expected: []sql.Row{},
2755+
},
2756+
{
2757+
Query: "CREATE TABLE t1 (pk int primary key);",
2758+
Expected: []sql.Row{},
2759+
},
2760+
{
2761+
Query: "SELECT DOLT_CLEAN();",
27552762
Expected: []sql.Row{{"{0}"}},
27562763
},
27572764
{
@@ -2769,12 +2776,10 @@ func TestDoltFunctionSmokeTests(t *testing.T) {
27692776
},
27702777
},
27712778
{
2772-
Skip: true, // TODO: function dolt_clean() does not exist
27732779
Query: "SELECT DOLT_CLEAN();",
27742780
Expected: []sql.Row{{"{0}"}},
27752781
},
27762782
{
2777-
Skip: true,
27782783
Query: "SELECT * FROM dolt.status;",
27792784
Expected: []sql.Row{},
27802785
},

0 commit comments

Comments
 (0)