Make UCO MethodDesc globals DAC-accessible (#126927)

Co-authored-by: Jan Kotas <jkotas@microsoft.com>

Author: am11

src/coreclr/debug/daccess/dacdbiimplstackwalk.cpp

@@ -297,12 +297,20 @@ HRESULT STDMETHODCALLTYPE DacDbiInterfaceImpl::UnwindStackWalkFrame(StackWalkHan
                 }
                 else if (pIter->GetFrameState() == StackFrameIterator::SFITER_FRAMELESS_METHOD)
                 {
-                    // Skip the new exception handling managed code, the debugger clients are not supposed to see them
                     MethodDesc *pMD = pIter->m_crawl.GetFunction();
+                    MethodTable *pMT = pMD->GetMethodTable();
 
+                    // Skip the exception handling managed code, the debugger clients are not supposed to see them
                     // EH.DispatchEx, EH.RhThrowEx, EH.RhThrowHwEx, ExceptionServices.InternalCalls.SfiInit, ExceptionServices.InternalCalls.SfiNext
                     // and System.Runtime.StackFrameIterator.*
-                    if (pMD->GetMethodTable() == g_pEHClass || pMD->GetMethodTable() == g_pExceptionServicesInternalCallsClass || pMD->GetMethodTable() == g_pStackFrameIteratorClass)
+                    if (pMT == g_pEHClass || pMT == g_pExceptionServicesInternalCallsClass || pMT == g_pStackFrameIteratorClass)
+                    {
+                        continue;
+                    }
+
+                    // Skip the runtime helper that invokes the main program entrypoint, the debuggers do not want to see it.
+                    // Environment.CallEntryPoint
+                    if (pMD == g_pEnvironmentCallEntryPointMethodDesc)
                     {
                         continue;
                     }
@@ -421,6 +429,11 @@ HRESULT STDMETHODCALLTYPE DacDbiInterfaceImpl::GetStackWalkCurrentFrameInfo(Stac
                         {
                             ftResult = kManagedExceptionHandlingCodeFrame;
                         }
+                        // Environment.CallEntryPoint
+                        else if (pMD == g_pEnvironmentCallEntryPointMethodDesc)
+                        {
+                            ftResult = kRuntimeEntryPointFrame;
+                        }
                         else
                         {
                             ftResult = kManagedStackFrame;

src/coreclr/debug/di/rsstackwalk.cpp

@@ -602,6 +602,11 @@ HRESULT CordbStackWalk::GetFrameWorker(ICorDebugFrame ** ppFrame)
         STRESS_LOG1(LF_CORDB, LL_INFO1000, "CSW::GFW - managed exception handling code frame (%p)", this);
         return S_FALSE;
     }
+    else if (ft == IDacDbiInterface::kRuntimeEntryPointFrame)
+    {
+        STRESS_LOG1(LF_CORDB, LL_INFO1000, "CSW::GFW - runtime entry point frame (%p)", this);
+        return S_FALSE;
+    }
     else if (ft == IDacDbiInterface::kExplicitFrame)
     {
         STRESS_LOG1(LF_CORDB, LL_INFO1000, "CSW::GFW - explicit frame (%p)", this);

src/coreclr/debug/ee/controller.cpp

@@ -6767,14 +6767,21 @@ bool DebuggerStepper::IsInterestingFrame(FrameInfo * pFrame)
 {
     LIMITED_METHOD_CONTRACT;
 
-    // Ignore managed exception handling frames
     if (pFrame->md != NULL)
     {
         MethodTable *pMT = pFrame->md->GetMethodTable();
+
+        // Ignore managed exception handling frames
         if ((pMT == g_pEHClass) || (pMT == g_pExceptionServicesInternalCallsClass))
         {
             return false;
         }
+
+        // Ignore the runtime helper that invokes the main program entrypoint
+        if (pFrame->md == g_pEnvironmentCallEntryPointMethodDesc)
+        {
+            return false;
+        }
     }
 
     return true;

src/coreclr/debug/inc/dacdbiinterface.h

@@ -1231,6 +1231,7 @@ IDacDbiInterface : public IUnknown
         kNativeStackFrame,
         kNativeRuntimeUnwindableStackFrame,
         kManagedExceptionHandlingCodeFrame,
+        kRuntimeEntryPointFrame,
         kAtEndOfStack,
     } FrameType;
 

src/coreclr/inc/dacvars.h

@@ -125,6 +125,8 @@ DEFINE_DACVAR(UNKNOWN_POINTER_TYPE, dac__g_pEHClass, ::g_pEHClass)
 DEFINE_DACVAR(UNKNOWN_POINTER_TYPE, dac__g_pExceptionServicesInternalCallsClass, ::g_pExceptionServicesInternalCallsClass)
 DEFINE_DACVAR(UNKNOWN_POINTER_TYPE, dac__g_pStackFrameIteratorClass, ::g_pStackFrameIteratorClass)
 
+DEFINE_DACVAR(UNKNOWN_POINTER_TYPE, dac__g_pEnvironmentCallEntryPointMethodDesc, ::g_pEnvironmentCallEntryPointMethodDesc)
+
 DEFINE_DACVAR(PTR_SString, SString__s_Empty, SString::s_Empty)
 
 DEFINE_DACVAR(INT32, ArrayBase__s_arrayBoundsZero, ArrayBase::s_arrayBoundsZero)

src/coreclr/vm/assembly.cpp

@@ -1165,8 +1165,6 @@ struct Param
     bool captureException;
 } param;
 
-MethodDesc* g_pEnvironmentCallEntryPointMethodDesc = nullptr;
-
 #if defined(TARGET_BROWSER)
 extern "C" void SystemJS_ResolveMainPromise(int exitCode);
 #endif // TARGET_BROWSER

src/coreclr/vm/debugdebugger.cpp

@@ -32,8 +32,6 @@
 
 #ifndef DACCESS_COMPILE
 
-extern MethodDesc* g_pEnvironmentCallEntryPointMethodDesc;
-
 //
 // Notes:
 //    If a managed debugger is attached, this should send the managed UserBreak event.

src/coreclr/vm/eepolicy.cpp

@@ -23,8 +23,6 @@
 #include "eventtrace.h"
 #undef ExitProcess
 
-extern MethodDesc* g_pEnvironmentCallEntryPointMethodDesc;
-
 void SafeExitProcess(UINT exitCode, ShutdownCompleteAction sca = SCA_ExitProcessWhenShutdownComplete)
 {
     STRESS_LOG2(LF_SYNC, LL_INFO10, "SafeExitProcess: exitCode = %d sca = %d\n", exitCode, sca);
@@ -180,7 +178,7 @@ class CallStackLogger
 
         MethodDesc* pMD = pCF->GetFunction();
 
-        // Skip Environment.CallEntryPoint so it doesn't appear in vanilla
+        // Skip Environment.CallEntryPoint so it doesn't appear in
         // unhandled exception experiences.
         if (pMD != nullptr && pMD == g_pEnvironmentCallEntryPointMethodDesc)
         {

src/coreclr/vm/exceptionhandling.cpp

@@ -18,7 +18,6 @@
 #include "exinfo.h"
 #include "configuration.h"
 
-extern MethodDesc* g_pEnvironmentCallEntryPointMethodDesc;
 extern MethodDesc* g_pThreadStartCallbackMethodDesc;
 extern MethodDesc* g_pGCRunFinalizersMethodDesc;
 

src/coreclr/vm/vars.cpp

@@ -112,6 +112,8 @@ GPTR_IMPL(MethodTable,      g_pEHClass);
 GPTR_IMPL(MethodTable,      g_pExceptionServicesInternalCallsClass);
 GPTR_IMPL(MethodTable,      g_pStackFrameIteratorClass);
 
+GPTR_IMPL(MethodDesc,       g_pEnvironmentCallEntryPointMethodDesc);
+
 GVAL_IMPL_INIT(PTR_WSTR, g_EntryAssemblyPath, NULL);
 
 #ifndef DACCESS_COMPILE