fix: copy dbt-origin dicts before mutation to fix fusion preview.134+ regression (#959)

* fix: copy dbt-origin dicts before mutation to fix fusion preview.134+ regression

Hypothesis: dbt-fusion preview.134+ changed internal dict/map types to be
immutable. Dicts originating from dbt internals (kwargs, model objects,
graph nodes) no longer support .update(). Locally-created dicts are fine.

Fix: wrap dbt-origin dicts with dict() to create mutable copies before
calling .update() on them:
- store_anomaly_test_results.sql: test_params from test_metadata.kwargs
- python.sql: test_node from context.model, test_node.config
- generate_json_schema_test.sql: node from get_node_by_name(), node.config

CI pinned to preview.143 (known-broken) to validate the hypothesis.

Co-Authored-By: Itamar Hartstein <haritamar@gmail.com>

* ci: remove fusion version pin — hypothesis confirmed

Fusion snowflake CI passed with preview.143 + dict() copies, confirming
that dbt-origin dicts just need to be copied before mutation. Remove the
version pin to use latest fusion.

Co-Authored-By: Itamar Hartstein <haritamar@gmail.com>

---------

Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-authored-by: Itamar Hartstein <haritamar@gmail.com>

Author: devin-ai-integration[bot]

.github/workflows/test-warehouse.yml

@@ -141,9 +141,7 @@ jobs:
       - name: Install dbt-fusion
         if: inputs.dbt-version == 'fusion'
         run: |
-          # Pin to preview.127 — later versions (134+) regress dict .update()/.pop().
-          # See https://github.com/elementary-data/dbt-data-reliability/pull/956 for bisect details.
-          curl -fsSL https://public.cdn.getdbt.com/fs/install/install.sh | sh -s -- --version 2.0.0-preview.127
+          curl -fsSL https://public.cdn.getdbt.com/fs/install/install.sh | sh -s --
 
       - name: Install Elementary
         run: pip install "./elementary[${{ (inputs.warehouse-type == 'databricks_catalog' && 'databricks') || inputs.warehouse-type }}]"

macros/commands/generate_json_schema_test.sql

@@ -15,8 +15,11 @@
 
     {% set elementary_database_name, elementary_schema_name = elementary.get_package_database_and_schema() %}
 
-    {% do node.config.update({"packages": ["genson"]}) %}
-    {% do node.update({'database': elementary_database_name, 'schema': elementary_schema_name}) %}
+    {# Copy node dict so we can mutate it — dbt graph nodes may be immutable maps in fusion #}
+    {% set node = dict(node) %}
+    {% set node_config = dict(node.get('config', {})) %}
+    {% do node_config.update({"packages": ["genson"]}) %}
+    {% do node.update({'config': node_config, 'database': elementary_database_name, 'schema': elementary_schema_name}) %}
     {% if node.resource_type == 'source' %}
       {# Source nodes don't have alias, and submit_python_job expects it #}
       {% do node.update({'alias': "jsonschemagen_{}_{}".format(node.source_name, node.name)}) %}

macros/edr/data_monitoring/anomaly_detection/store_anomaly_test_results.sql

@@ -21,7 +21,7 @@
   {%- set full_table_name = elementary.insensitive_get_dict_value(latest_row, 'full_table_name') %}
   {%- set test_unique_id = flattened_test.unique_id %}
   {%- set test_configuration = elementary.get_cache(test_unique_id) %}
-  {%- set test_params = elementary.insensitive_get_dict_value(flattened_test, 'test_params') %}
+  {%- set test_params = dict(elementary.insensitive_get_dict_value(flattened_test, 'test_params')) %}
   {%- do test_params.update(test_configuration) %}
   {%- set parent_model_unique_id = elementary.insensitive_get_dict_value(flattened_test, 'parent_model_unique_id') %}
   {%- set column_name = elementary.insensitive_get_dict_value(latest_row, 'column_name') %}

macros/edr/tests/python.sql

@@ -17,7 +17,7 @@
   {% endif %}
 
   {% set test_args = kwargs %}
-  {% set test_node = context.model %}
+  {% set test_node = dict(context.model) %}
   {% set model_relation = model.quote(false, false, false) %}
   {% set elementary_database_name, elementary_schema_name = elementary.get_package_database_and_schema() %}
   {% set output_table = api.Relation.create(database=elementary_database_name, schema=elementary_schema_name,
@@ -30,7 +30,9 @@
      #}
   {% do test_node.update({'database': elementary_database_name, 'schema': elementary_schema_name}) %}
 
-  {% do test_node.config.update(test_args) %}
+  {% set config_copy = dict(test_node.get('config', {})) %}
+  {% do config_copy.update(test_args) %}
+  {% do test_node.update({'config': config_copy}) %}
 
   {% if code_macro is string %}
     {% set user_py_code_macro = context[code_macro] %}