fix: add spark address valid check in displayAddress method

Author: narekpetrosyan

packages/extension/src/libs/spark-handler/index.ts

@@ -26,3 +26,11 @@ export async function sendToSparkAddress(to: string, amount: string) {
     },
   ]);
 }
+
+export async function sendFromSparkAddress(to: string, amount: string) {
+  return await callRPC<string[]>("spendspark", [
+    {
+      [to]: { amount: Number(amount) },
+    },
+  ]);
+}

packages/extension/src/providers/bitcoin/types/bitcoin-network.ts

@@ -57,7 +57,9 @@ export interface BitcoinNetworkOptions {
 }
 
 export const getAddress = (pubkey: string, network: BitcoinNetworkInfo) => {
-  if (pubkey.length < 64) return pubkey;
+  if (pubkey.length >= 144 || pubkey.length < 64) {
+    return pubkey;
+  }
   const { address } = payments[network.paymentType]({
     network,
     pubkey: hexToBuffer(pubkey),

packages/extension/src/ui/action/views/verify-send-from-spark-transaction/index.vue

@@ -75,7 +75,6 @@ import BaseButton from "@action/components/base-button/index.vue";
 import VerifyTransactionNetwork from "@/providers/common/ui/verify-transaction/verify-transaction-network.vue";
 import VerifyTransactionAccount from "@/providers/common/ui/verify-transaction/verify-transaction-account.vue";
 import VerifyTransactionAmount from "@/providers/common/ui/verify-transaction/verify-transaction-amount.vue";
-import VerifyTransactionFee from "@/providers/common/ui/verify-transaction/verify-transaction-fee.vue";
 import SendProcess from "@action/views/send-process/index.vue";
 import { getCurrentContext } from "@/libs/messenger/extension";
 import { DEFAULT_BTC_NETWORK, getNetworkByName } from "@/libs/utils/networks";
@@ -86,11 +85,10 @@ import { BitcoinNetwork } from "@/providers/bitcoin/types/bitcoin-network";
 import { trackSendEvents } from "@/libs/metrics";
 import { SendEventType } from "@/libs/metrics/types";
 import { VerifyTransactionParams } from "@/providers/bitcoin/ui/types";
-import { sendToSparkAddress } from "@/libs/spark-handler";
+import { sendFromSparkAddress } from "@/libs/spark-handler";
 import { isAxiosError } from "axios";
 import { fromBase } from "@enkryptcom/utils";
 import { BaseNetwork } from "@/types/base-network";
-import { isAddress } from "@/providers/bitcoin/libs/utils";
 
 const emits = defineEmits<{
   (e: "update:spark-state-changed", network: BaseNetwork): void;
@@ -132,7 +130,6 @@ const sendAction = async () => {
     network: network.value.name,
   });
   const txActivity: Activity = {
-    // TODO: finalize send from spark account
     from: network.value.displayAddress(txData.fromAddress),
     to: txData.toAddress,
     isIncoming: txData.fromAddress === txData.toAddress,
@@ -151,7 +148,7 @@ const sendAction = async () => {
     transactionHash: "",
   };
   const activityState = new ActivityState();
-  await sendToSparkAddress(
+  await sendFromSparkAddress(
     txData.toAddress,
     fromBase(txData.toToken.amount, txData.toToken.decimals).toString()
   )