fix: rtol ltol issue

Author: kvhnuke

packages/extension/src/libs/utils/unicode-detection.ts

@@ -0,0 +1,22 @@
+const fixedHex = (number: number, length: number) => {
+  let str = number.toString(16).toUpperCase();
+  while (str.length < length) str = '0' + str;
+  return str;
+};
+
+/* Creates a unicode literal based on the string */
+const unicodeLiteral = (str: string) => {
+  let i;
+  let result = '';
+  for (i = 0; i < str.length; ++i) {
+    if (str.charCodeAt(i) > 126 || str.charCodeAt(i) < 32)
+      result += '\\u' + fixedHex(str.charCodeAt(i), 4);
+    else result += str[i];
+  }
+  return result;
+};
+export const getRTLOLTLOSafeString = (str: string): string => {
+  const isrtloltlo = /[\u202E\u200F]/.test(str) || /[\u202D\u200E]/.test(str);
+  if (isrtloltlo) return unicodeLiteral(str);
+  return str;
+};

packages/extension/src/providers/bitcoin/ui/btc-sign-message.vue

@@ -65,6 +65,7 @@ import { ProviderRequestOptions } from '@/types/provider';
 import { BitcoinNetwork } from '../types/bitcoin-network';
 import { EnkryptAccount } from '@enkryptcom/types';
 import { MessageSigner } from './libs/signer';
+import { getRTLOLTLOSafeString } from '@/libs/utils/unicode-detection';
 
 const windowPromise = WindowPromiseHandler(4);
 const network = ref<BitcoinNetwork>(DEFAULT_BTC_NETWORK);
@@ -92,7 +93,7 @@ onBeforeMount(async () => {
   account.value = Request.value.params![2] as EnkryptAccount;
   identicon.value = network.value.identicon(account.value.address);
   Options.value = options;
-  message.value = Request.value.params![0];
+  message.value = getRTLOLTLOSafeString(Request.value.params![0]);
   type.value = Request.value.params![1];
 });
 

packages/extension/src/providers/ethereum/ui/eth-sign-message.vue

@@ -59,6 +59,7 @@ import HardwareWalletMsg from '@/providers/common/ui/verify-transaction/hardware
 import { EvmNetwork } from '../types/evm-network';
 import { EnkryptAccount } from '@enkryptcom/types';
 import { MessageSigner } from './libs/signer';
+import { getRTLOLTLOSafeString } from '@/libs/utils/unicode-detection';
 
 const windowPromise = WindowPromiseHandler(3);
 const network = ref<EvmNetwork>(DEFAULT_EVM_NETWORK);
@@ -85,7 +86,7 @@ onBeforeMount(async () => {
   identicon.value = network.value.identicon(account.value.address);
   Options.value = options;
   message.value = isUtf8(Request.value.params![0])
-    ? hexToUtf8(Request.value.params![0])
+    ? getRTLOLTLOSafeString(hexToUtf8(Request.value.params![0]))
     : Request.value.params![0];
 });
 

packages/extension/src/providers/kadena/ui/kda-sign-message.vue

@@ -64,6 +64,7 @@ import {
   DEFAULT_KADENA_NETWORK,
   getNetworkByName,
 } from '@/libs/utils/networks';
+import { getRTLOLTLOSafeString } from '@/libs/utils/unicode-detection';
 
 const windowPromise = WindowPromiseHandler(0);
 const network = ref<KadenaNetwork>(DEFAULT_KADENA_NETWORK);
@@ -81,7 +82,7 @@ const account = ref({ address: '' } as EnkryptAccount);
 onBeforeMount(async () => {
   const { Request, options } = await windowPromise;
   Options.value = options;
-  message.value = Request.value.params![0].data;
+  message.value = getRTLOLTLOSafeString(Request.value.params![0].data);
   account.value = Request.value.params![1] as EnkryptAccount;
   network.value = (await getNetworkByName(
     Request.value.params![0].network,

packages/extension/src/providers/polkadot/ui/dot-sign-message.vue

@@ -56,6 +56,7 @@ import { ProviderRequestOptions } from '@/types/provider';
 import { EnkryptAccount } from '@enkryptcom/types';
 import { MessageSigner } from './libs/signer';
 import { hexToBuffer } from '@enkryptcom/utils';
+import { getRTLOLTLOSafeString } from '@/libs/utils/unicode-detection';
 
 const windowPromise = WindowPromiseHandler(0);
 
@@ -74,7 +75,9 @@ onBeforeMount(async () => {
   Options.value = options;
 
   message.value = isUtf8(Request.value.params![0])
-    ? u8aToString(u8aUnwrapBytes(Request.value.params![0]))
+    ? getRTLOLTLOSafeString(
+        u8aToString(u8aUnwrapBytes(Request.value.params![0])),
+      )
     : Request.value.params![0];
 
   account.value = Request.value.params![1] as EnkryptAccount;

packages/extension/src/providers/solana/ui/sol-sign-message.vue

@@ -76,6 +76,7 @@ import { SolSignInResponse } from './types';
 import { isUtf8 } from '@polkadot/util';
 import { hexToUtf8 } from 'web3-utils';
 import { MessageSigner } from './libs/signer';
+import { getRTLOLTLOSafeString } from '@/libs/utils/unicode-detection';
 
 const windowPromise = WindowPromiseHandler(3);
 const keyring = new PublicKeyRing();
@@ -144,7 +145,7 @@ onBeforeMount(async () => {
   } else if (reqMethod.value === 'sol_signMessage') {
     signMessage.value = JSON.parse(Request.value.params![1]);
     message.value = isUtf8(signMessage.value!.message)
-      ? hexToUtf8(signMessage.value!.message)
+      ? getRTLOLTLOSafeString(hexToUtf8(signMessage.value!.message))
       : signMessage.value!.message;
     keyring
       .getAccount(bufferToHex(bs58.decode(signMessage.value!.address)))