Skip to content

Commit eacd174

Browse files
authored
bridge: fix up proto registration (#2702)
This fixes up issues exposed in envoyproxy/envoy#24151 where the PlatformBridgeCertValidatorFactory was not associated with the PlatformBridgeCertValidator proto. Risk Level: low Testing: envoyproxy/envoy#24151 Docs Changes: n/a Release Notes: n/a Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
1 parent e06299f commit eacd174

1 file changed

Lines changed: 8 additions & 1 deletion

File tree

  • library/common/extensions/cert_validator/platform_bridge

library/common/extensions/cert_validator/platform_bridge/config.h

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,21 +2,28 @@
22

33
#include "source/extensions/transport_sockets/tls/cert_validator/factory.h"
44

5+
#include "library/common/extensions/cert_validator/platform_bridge/platform_bridge.pb.h"
56
#include "library/common/extensions/cert_validator/platform_bridge/platform_bridge_cert_validator.h"
67

78
namespace Envoy {
89
namespace Extensions {
910
namespace TransportSockets {
1011
namespace Tls {
1112

12-
class PlatformBridgeCertValidatorFactory : public CertValidatorFactory {
13+
class PlatformBridgeCertValidatorFactory : public CertValidatorFactory,
14+
public Config::TypedFactory {
1315
public:
1416
CertValidatorPtr createCertValidator(const Envoy::Ssl::CertificateValidationContextConfig* config,
1517
SslStats& stats, TimeSource& time_source) override;
1618

1719
std::string name() const override {
1820
return "envoy_mobile.cert_validator.platform_bridge_cert_validator";
1921
}
22+
ProtobufTypes::MessagePtr createEmptyConfigProto() override {
23+
return std::make_unique<
24+
envoy_mobile::extensions::cert_validator::platform_bridge::PlatformBridgeCertValidator>();
25+
}
26+
std::string category() const override { return "envoy.tls.cert_validator"; }
2027

2128
private:
2229
const envoy_cert_validator* platform_validator_ = nullptr;

0 commit comments

Comments
 (0)