build: removing admin (#2693)

Removing Admin from release builds by default

Risk Level: medium
Testing: n/a
Docs Changes: n/a
Release Notes: inline

Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: alyssawilk <alyssar@google.com>
Co-authored-by: JP Simard <jp@jpsim.com>

Author: alyssawilk

.bazelrc

@@ -101,7 +101,7 @@ build:tsan-dev --test_env="TSAN_OPTIONS=report_atomic_races=0"
 build:release-common --define=no_debug_info=1
 
 # Compile releases optimizing for size (eg -Os, etc).
-build:release-common --config=sizeopt
+build:release-common --config=sizeopt --define=admin_functionality=disabled
 
 # Set default symbols visibility to hidden to reduce .dynstr and the symbol table size
 build:release-common --copt=-fvisibility=hidden

docs/root/intro/version_history.rst

@@ -10,6 +10,7 @@ Breaking changes:
 - build: building on macOS now requires Xcode 14.1. (:issue:`#2664 <2664>`)
 - iOS: remove experimental option to force all connections to use IPv6.
 - kotlin: always use ``getaddrinfo`` DNS resolver. Remove ``addDNSFallbackNameservers``, ``enableDNSFilterUnroutableFamilies``, and ``enableDNSUseSystemResolver`` methods from the Kotlin engine builder. (:issue:`#2618 <2618>`)
+- Envoy Mobile's release builds compile without admin support by default. (``--define=admin_functionality=disabled``) (:issue`#2693 <2693>`)
 
 Bugfixes:
 

library/kotlin/io/envoyproxy/envoymobile/EngineBuilder.kt

@@ -560,6 +560,9 @@ open class EngineBuilder(
    * used for development/debugging purposes only. Enabling it in production may open
    * your app to security vulnerabilities.
    *
+   * Note this will not work with the default production build, as it builds with admin
+   * functionality disabled via --define=admin_functionality=disabled
+   *
    * @return this builder.
    */
   fun enableAdminInterface(): EngineBuilder {

library/swift/EngineBuilder.swift

@@ -487,6 +487,9 @@ open class EngineBuilder: NSObject {
   /// used for development/debugging purposes only. Enabling it in production may open
   /// your app to security vulnerabilities.
   ///
+  /// Note this will not work with the default production build, as it builds with admin
+  /// functionality disabled via --define=admin_functionality=disabled
+  ///
   /// - returns: This builder.
   @discardableResult
   public func enableAdminInterface() -> Self {