Skip to content

Commit 22fc6a6

Browse files
fix(langchain): Record run_name as gen_ai.function_id for text completions (#6073)
Set the `run_name` LangChain attribute as the `gen_ai.function_id` attribute in `on_llm_start`.
1 parent 82c1de4 commit 22fc6a6

2 files changed

Lines changed: 5 additions & 5 deletions

File tree

sentry_sdk/integrations/langchain.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -346,9 +346,9 @@ def on_llm_start(
346346

347347
span.set_data(SPANDATA.GEN_AI_OPERATION_NAME, "text_completion")
348348

349-
pipeline_name = kwargs.get("name")
350-
if pipeline_name:
351-
span.set_data(SPANDATA.GEN_AI_PIPELINE_NAME, pipeline_name)
349+
run_name = kwargs.get("name")
350+
if run_name:
351+
span.set_data(SPANDATA.GEN_AI_FUNCTION_ID, run_name)
352352

353353
if model:
354354
span.set_data(

tests/integrations/langchain/test_langchain.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -324,7 +324,7 @@ def test_langchain_text_completion(
324324
llm_span = llm_spans[0]
325325
assert llm_span["description"] == "text_completion gpt-3.5-turbo"
326326
assert llm_span["data"]["gen_ai.system"] == "openai"
327-
assert llm_span["data"]["gen_ai.pipeline.name"] == "my-snazzy-pipeline"
327+
assert llm_span["data"]["gen_ai.function_id"] == "my-snazzy-pipeline"
328328
assert llm_span["data"]["gen_ai.request.model"] == "gpt-3.5-turbo"
329329
assert llm_span["data"]["gen_ai.response.text"] == "The capital of France is Paris."
330330
assert llm_span["data"]["gen_ai.usage.total_tokens"] == 25
@@ -1983,7 +1983,7 @@ def test_langchain_message_truncation(sentry_init, capture_events):
19831983

19841984
llm_span = llm_spans[0]
19851985
assert llm_span["data"]["gen_ai.operation.name"] == "text_completion"
1986-
assert llm_span["data"][SPANDATA.GEN_AI_PIPELINE_NAME] == "my_pipeline"
1986+
assert llm_span["data"][SPANDATA.GEN_AI_FUNCTION_ID] == "my_pipeline"
19871987

19881988
assert SPANDATA.GEN_AI_REQUEST_MESSAGES in llm_span["data"]
19891989
messages_data = llm_span["data"][SPANDATA.GEN_AI_REQUEST_MESSAGES]

0 commit comments

Comments
 (0)