Skip to content

Commit 9929f55

Browse files
.
1 parent b1fa3b5 commit 9929f55

1 file changed

Lines changed: 24 additions & 7 deletions

File tree

tests/integrations/django/test_basic.py

Lines changed: 24 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -596,7 +596,9 @@ def test_django_connect_trace(sentry_init, client, capture_events, render_span_t
596596
data = span.get("data")
597597
assert data.get(SPANDATA.DB_SYSTEM) == "postgresql"
598598

599-
assert '- op="db": description="connect"' in render_span_tree(event)
599+
assert '- op="db": description="connect"' in render_span_tree(
600+
event["spans"], event["contexts"]["trace"]
601+
)
600602

601603

602604
@pytest.mark.forked
@@ -954,7 +956,9 @@ def test_render_spans(sentry_init, client, capture_events, render_span_tree):
954956
events = capture_events()
955957
client.get(url)
956958
transaction = events[0]
957-
assert expected_line in render_span_tree(transaction)
959+
assert expected_line in render_span_tree(
960+
transaction["spans"], transaction["contexts"]["trace"]
961+
)
958962

959963

960964
@pytest.mark.skipif(DJANGO_VERSION < (1, 9), reason="Requires Django >= 1.9")
@@ -1034,7 +1038,10 @@ def test_middleware_spans(sentry_init, client, capture_events, render_span_tree)
10341038
message, transaction = events
10351039

10361040
assert message["message"] == "hi"
1037-
assert render_span_tree(transaction) == EXPECTED_MIDDLEWARE_SPANS
1041+
assert (
1042+
render_span_tree(transaction["spans"], transaction["contexts"]["trace"])
1043+
== EXPECTED_MIDDLEWARE_SPANS
1044+
)
10381045

10391046

10401047
def test_middleware_spans_disabled(sentry_init, client, capture_events):
@@ -1075,7 +1082,10 @@ def test_signals_spans(sentry_init, client, capture_events, render_span_tree):
10751082
message, transaction = events
10761083

10771084
assert message["message"] == "hi"
1078-
assert render_span_tree(transaction) == EXPECTED_SIGNALS_SPANS
1085+
assert (
1086+
render_span_tree(transaction["spans"], transaction["contexts"]["trace"])
1087+
== EXPECTED_SIGNALS_SPANS
1088+
)
10791089

10801090
assert transaction["spans"][0]["op"] == "event.django"
10811091
assert transaction["spans"][0]["description"] == "django.db.reset_queries"
@@ -1127,7 +1137,10 @@ def test_signals_spans_filtering(sentry_init, client, capture_events, render_spa
11271137

11281138
(transaction,) = events
11291139

1130-
assert render_span_tree(transaction) == EXPECTED_SIGNALS_SPANS_FILTERED
1140+
assert (
1141+
render_span_tree(transaction["spans"], transaction["contexts"]["trace"])
1142+
== EXPECTED_SIGNALS_SPANS_FILTERED
1143+
)
11311144

11321145
assert transaction["spans"][0]["op"] == "event.django"
11331146
assert transaction["spans"][0]["description"] == "django.db.reset_queries"
@@ -1206,7 +1219,9 @@ def test_custom_urlconf_middleware(
12061219
event = events.pop(0)
12071220
assert event["transaction"] == "/custom/ok"
12081221
if middleware_spans:
1209-
assert "custom_urlconf_middleware" in render_span_tree(event)
1222+
assert "custom_urlconf_middleware" in render_span_tree(
1223+
event["spans"], event["contexts"]["trace"]
1224+
)
12101225

12111226
_content, status, _headers = unpack_werkzeug_response(client.get("/custom/exc"))
12121227
assert status.lower() == "500 internal server error"
@@ -1216,7 +1231,9 @@ def test_custom_urlconf_middleware(
12161231
assert error_event["exception"]["values"][-1]["mechanism"]["type"] == "django"
12171232
assert transaction_event["transaction"] == "/custom/exc"
12181233
if middleware_spans:
1219-
assert "custom_urlconf_middleware" in render_span_tree(transaction_event)
1234+
assert "custom_urlconf_middleware" in render_span_tree(
1235+
transaction_event["spans"], transaction_event["contexts"]["trace"]
1236+
)
12201237

12211238
settings.MIDDLEWARE.pop(0)
12221239

0 commit comments

Comments
 (0)