+ "details": "### Summary\n\nThe `SanitizeSVG` function introduced in v3.6.0 to fix XSS in the unauthenticated `/api/icon/getDynamicIcon` endpoint can be bypassed by using namespace-prefixed element names such as `<x:script xmlns:x=\"http://www.w3.org/2000/svg\">`. The Go HTML5 parser records the element's tag as `\"x:script\"` rather than `\"script\"`, so the tag check passes it through. The SVG is served with `Content-Type: image/svg+xml` and no Content Security Policy; when a browser opens the response directly, its XML parser resolves the prefix to the SVG namespace and executes the embedded script.\n\n### Details\n\nThe `getDynamicIcon` route is registered without authentication:\n\n```go\n// kernel/server/serve.go\nginServer.Handle(\"GET\", \"/api/icon/getDynamicIcon\", getDynamicIcon)\n```\n\nFor type 8, the `content` query parameter is inserted directly into an SVG `<text>` element using `fmt.Sprintf` with no HTML encoding:\n\n```go\n// kernel/api/icon.go:579-584\nreturn fmt.Sprintf(`\n <svg id=\"dynamic_icon_type8\" xmlns=\"http://www.w3.org/2000/svg\" viewBox=\"0 0 512 512\">\n <path d=\"...\"/>\n <text x=\"50%%\" y=\"55%%\" ...>%s</text>\n </svg>`, ..., content)\n```\n\n`SanitizeSVG` then parses the SVG with `github.com/88250/lute/html` and removes elements whose lowercased tag name matches a fixed list:\n\n```go\n// kernel/util/misc.go:249-252\ntag := strings.ToLower(c.Data)\nif tag == \"script\" || tag == \"iframe\" || tag == \"object\" || tag == \"embed\" ||\n tag == \"foreignobject\" || \"animate\" == tag || ... {\n n.RemoveChild(c)\n```\n\nThe lute HTML parser stores the full qualified name including any namespace prefix in `Node.Data`. A payload like `<x:script xmlns:x=\"http://www.w3.org/2000/svg\">` gets `Data = \"x:script\"`. The check `tag == \"script\"` is false, so the element is not removed and survives in the rendered output.\n\nConfirmed with the same library version used by SiYuan:\n\n```\nhtml.Parse input: <x:script xmlns:x=\"http://www.w3.org/2000/svg\">alert(1)</x:script>\nNode.Data result: \"x:script\" (not \"script\")\nRemoved by check: false\nRendered output: <x:script xmlns:x=\"http://www.w3.org/2000/svg\">alert(1)</x:script>\n```\n\nThe same bypass works for every element on the blocklist: `x:iframe`, `x:object`, `x:foreignObject`, etc.\n\nThe fix is to strip the namespace prefix before comparing:\n\n```go\nlocalName := tag\nif i := strings.LastIndex(tag, \":\"); i >= 0 {\n localName = tag[i+1:]\n}\nif localName == \"script\" || localName == \"iframe\" || ...\n```\n\n### PoC\n\n```\nGET /api/icon/getDynamicIcon?type=8&color=red&content=%3C%2Ftext%3E%3Cx%3Ascript%20xmlns%3Ax%3D%22http%3A%2F%2Fwww.w3.org%2F2000%2Fsvg%22%3Ealert%28document.domain%29%3C%2Fx%3Ascript%3E%3Ctext%3E HTTP/1.1\nHost: 127.0.0.1:6806\n```\n\nDecoded `content` value:\n```\n</text><x:script xmlns:x=\"http://www.w3.org/2000/svg\">alert(document.domain)</x:script><text>\n```\n\nThe response is a valid SVG with the script element intact. Opening the URL directly in a browser triggers the alert, confirming script execution at the SiYuan server origin.\n\n### Impact\n\nAny user whose SiYuan instance is reachable over a local network is exposed. An attacker on the same network can craft the URL and share it. When the victim opens it in a browser, JavaScript executes at the `http://<siyuan-host>:6806` origin. Because SiYuan sets `Access-Control-Allow-Origin: *` and the script runs same-origin, it can call any API endpoint using the victim's existing session cookies, including endpoints to read all notes, export data, or modify settings. No authentication or prior access is needed to construct the payload.",
![advisory-database[bot]](https://avatars.githubusercontent.com/in/21409?v=4&size=40){kind=avatar}
0 commit comments