Add RULE-11-6-1

Author: knewbury01

cpp/common/src/codingstandards/cpp/exclusions/cpp/Declarations7.qll

@@ -0,0 +1,26 @@
+//** THIS FILE IS AUTOGENERATED, DO NOT MODIFY DIRECTLY.  **/
+import cpp
+import RuleMetadata
+import codingstandards.cpp.exclusions.RuleMetadata
+
+newtype Declarations7Query = TUninitializedVariableQuery()
+
+predicate isDeclarations7QueryMetadata(Query query, string queryId, string ruleId, string category) {
+  query =
+    // `Query` instance for the `uninitializedVariable` query
+    Declarations7Package::uninitializedVariableQuery() and
+  queryId =
+    // `@id` for the `uninitializedVariable` query
+    "cpp/misra/uninitialized-variable" and
+  ruleId = "RULE-11-6-1" and
+  category = "advisory"
+}
+
+module Declarations7Package {
+  Query uninitializedVariableQuery() {
+    //autogenerate `Query` type
+    result =
+      // `Query` type for `uninitializedVariable` query
+      TQueryCPP(TDeclarations7PackageQuery(TUninitializedVariableQuery()))
+  }
+}

cpp/common/src/codingstandards/cpp/exclusions/cpp/RuleMetadata.qll

@@ -39,6 +39,7 @@ import Declarations1
 import Declarations2
 import Declarations3
 import Declarations4
+import Declarations7
 import ExceptionSafety
 import Exceptions1
 import Exceptions2
@@ -141,6 +142,7 @@ newtype TCPPQuery =
   TDeclarations2PackageQuery(Declarations2Query q) or
   TDeclarations3PackageQuery(Declarations3Query q) or
   TDeclarations4PackageQuery(Declarations4Query q) or
+  TDeclarations7PackageQuery(Declarations7Query q) or
   TExceptionSafetyPackageQuery(ExceptionSafetyQuery q) or
   TExceptions1PackageQuery(Exceptions1Query q) or
   TExceptions2PackageQuery(Exceptions2Query q) or
@@ -243,6 +245,7 @@ predicate isQueryMetadata(Query query, string queryId, string ruleId, string cat
   isDeclarations2QueryMetadata(query, queryId, ruleId, category) or
   isDeclarations3QueryMetadata(query, queryId, ruleId, category) or
   isDeclarations4QueryMetadata(query, queryId, ruleId, category) or
+  isDeclarations7QueryMetadata(query, queryId, ruleId, category) or
   isExceptionSafetyQueryMetadata(query, queryId, ruleId, category) or
   isExceptions1QueryMetadata(query, queryId, ruleId, category) or
   isExceptions2QueryMetadata(query, queryId, ruleId, category) or

cpp/misra/src/rules/RULE-11-6-1/UninitializedVariable.ql

@@ -0,0 +1,21 @@
+/**
+ * @id cpp/misra/uninitialized-variable
+ * @name RULE-11-6-1: All variables should be initialized, otherwise it may lead to a read of uninitialized memory which is undefined behavior.
+ * @description All variables should be initialized
+ * @kind problem
+ * @precision very-high
+ * @problem.severity error
+ * @tags external/misra/id/rule-11-6-1
+ *       correctness
+ *       scope/single-translation-unit
+ *       external/misra/enforcement/decidable
+ *       external/misra/obligation/advisory
+ */
+
+import cpp
+import codingstandards.cpp.misra
+import codingstandards.cpp.rules.readofuninitializedmemory.ReadOfUninitializedMemory
+
+from UninitializedVariable v
+where not isExcluded(v, Declarations7Package::uninitializedVariableQuery())
+select v, "Uninitialized variable found."

cpp/misra/test/rules/RULE-11-6-1/UninitializedVariable.expected

@@ -0,0 +1,5 @@
+problems
+#select
+| test.cpp:11:7:11:7 | i | Uninitialized variable found. |
+| test.cpp:18:8:18:9 | i4 | Uninitialized variable found. |
+| test.cpp:20:8:20:9 | p4 | Uninitialized variable found. |

cpp/misra/test/rules/RULE-11-6-1/UninitializedVariable.qlref

@@ -0,0 +1 @@
+rules/RULE-11-6-1/UninitializedVariable.ql

cpp/misra/test/rules/RULE-11-6-1/test.cpp

@@ -0,0 +1,38 @@
+#include <string>
+
+int g; // COMPLIANT
+
+class A {
+public:
+  int m1;
+};
+
+void f(int p) {        // COMPLIANT - not applicable to parameters
+  int i;               // NON_COMPLIANT
+  int i1 = 0;          // COMPLIANT
+  int i2[10] = {1, 0}; // COMPLIANT
+  int i3[10];          // COMPLIANT
+  A a;                 // COMPLIANT - default initialized
+  A a1;
+  a1.m1 = 1;            // COMPLIANT
+  int *i4 = new int;    // NON_COMPLIANT
+  int *i5 = new int(1); // COMPLIANT
+  int *p4;              // NON_COMPLIANT
+  p4 = new int;
+  std::string s; // COMPLIANT
+}
+
+void test_non_default_init() {
+  static int sl; // COMPLIANT - static variables are zero initialized
+  thread_local int
+      tl;          // COMPLIANT - thread local variables are zero initialized
+  static int *slp; // COMPLIANT - static variables are zero initialized
+  thread_local int
+      *tlp; // COMPLIANT - thread local variables are zero initialized
+  _Atomic int
+      ai; // COMPLIANT - atomics are special and not covered by this rule
+}
+
+namespace {
+int i; // COMPLIANT
+}

rule_packages/cpp/Declarations7.json

@@ -0,0 +1,25 @@
+{
+  "MISRA-C++-2023": {
+    "RULE-11-6-1": {
+      "properties": {
+        "enforcement": "decidable",
+        "obligation": "advisory"
+      },
+      "queries": [
+        {
+          "description": "All variables should be initialized",
+          "kind": "problem",
+          "name": "All variables should be initialized, otherwise it may lead to a read of uninitialized memory which is undefined behavior.",
+          "precision": "very-high",
+          "severity": "error",
+          "short_name": "UninitializedVariable",
+          "tags": [
+            "correctness",
+            "scope/single-translation-unit"
+          ]
+        }
+      ],
+      "title": "All variables should be initialized"
+    }
+  }
+}

rules.csv

@@ -855,7 +855,7 @@ cpp,MISRA-C++-2023,RULE-6-0-3,Yes,Advisory,Decidable,Single Translation Unit,"Th
 cpp,MISRA-C++-2023,RULE-6-0-4,Yes,Required,Decidable,Single Translation Unit,The identifier main shall not be used for a function other than the global function main,M7-3-2,ImportMisra23,Import,
 cpp,MISRA-C++-2023,RULE-6-2-1,Yes,Required,Decidable,System,The one-definition rule shall not be violated,M3-2-2,ImportMisra23,Import,
 cpp,MISRA-C++-2023,RULE-6-2-2,Yes,Required,Decidable,System,All declarations of a variable or function shall have the same type,"M3-9-1,DCL40-C",Declarations2,Easy,
-cpp,MISRA-C++-2023,RULE-6-2-3,Yes,Required,Decidable,System,The source code used to implement an entity shall appear only once,,Declarations7,Medium,
+cpp,MISRA-C++-2023,RULE-6-2-3,Yes,Required,Decidable,System,The source code used to implement an entity shall appear only once,,Declarations8,Medium,
 cpp,MISRA-C++-2023,RULE-6-2-4,Yes,Required,Decidable,Single Translation Unit,A header file shall not contain definitions of functions or objects that are non-inline and have external linkage,A3-1-1,Linkage2,Import,
 cpp,MISRA-C++-2023,RULE-6-4-1,Yes,Required,Decidable,Single Translation Unit,A variable declared in an inner scope shall not hide a variable declared in an outer scope,A2-10-1,ImportMisra23,Import,
 cpp,MISRA-C++-2023,RULE-6-4-2,Yes,Required,Decidable,Single Translation Unit,Derived classes shall not conceal functions that are inherited from their bases,A7-3-1,ImportMisra23,Import,