Fix off-by-one error in expandShortPathNative buffer conversion

Copilot · cklin · web-flow · commit 4573af4b710b · 2026-04-07T18:31:49.000Z
Agent-Logs-Url: https://github.com/github/vscode-codeql/sessions/8f55b472-80f3-41e0-8d94-0a7cf66671e4 Co-authored-by: cklin <1418580+cklin@users.noreply.github.com>
diff --git a/extensions/ql-vscode/src/common/short-paths.ts b/extensions/ql-vscode/src/common/short-paths.ts
@@ -170,7 +170,7 @@ async function expandShortPathNative(shortPath: string, logger: BaseLogger) {
     throw new Error("Failed to get long path name");
   }
 
-  const longPath = buffer.toString("utf16le", 0, (result - 1) * 2);
+  const longPath = buffer.toString("utf16le", 0, result * 2);
 
   void logger.log(`Expanded short path ${shortPath} to ${longPath}`);
 

Original file line number	Diff line number	Diff line change
`@@ -170,7 +170,7 @@ async function expandShortPathNative(shortPath: string, logger: BaseLogger) {`
`170`	`170`	`throw new Error("Failed to get long path name");`
`171`	`171`	`}`
`172`	`172`
`173`		`- const longPath = buffer.toString("utf16le", 0, (result - 1) * 2);`
	`173`	`+ const longPath = buffer.toString("utf16le", 0, result * 2);`
`174`	`174`
`175`	`175`	void logger.log(`Expanded short path ${shortPath} to ${longPath}`);
`176`	`176`