Replace srcset image URLs

Fixes product URLs not showing for https tunnels

Author: bekarice

README.md

@@ -47,6 +47,7 @@ Download and install just like any other WordPress plugin. If you want to be rea
 ### 1.0.0 - 2018-11-06
  * Refactor - Use namespaces and rename classes
  * Tweak - Add support for ngrok
+ * Fix - Ensure images load for products when using an https tunnel
 
 ### 0.8.1 - 2017.12.13
  * Fix - Remove WC 3.3+ "Connect to WooCommerce" notice when official plugins are active

includes/Forwarded_URLs.php

@@ -34,6 +34,9 @@ class Forwarded_URLs {
 	/** @var string non-forwarded host as defined in the siteurl option */
 	public $non_forwarded_host;
 
+	/** @var array values to find and replace in URLS */
+	private $find_replace = [];
+
 
 	/**
 	 * Setup filters
@@ -94,6 +97,7 @@ public function __construct() {
 			'stylesheet_directory_uri',
 			'the_content',
 			'the_content_pre',
+			'wp_calculate_image_srcset',
 		);
 
 		foreach ( $filters as $filter ) {
@@ -156,14 +160,37 @@ public function replace_with_forwarded_url( $content ) {
 		$non_forwarded_host = $this->non_forwarded_host;
 		$forwarded_host     = $this->get_forwarded_host();
 
-		// http, https and protocol-less URLs
-		$find_replace = array(
+		// http, https, and protocol-less URLs
+		$this->find_replace = [
 			"http://{$non_forwarded_host}"  => "http://{$forwarded_host}",
 			"https://{$non_forwarded_host}" => "https://{$forwarded_host}",
 			"//{$non_forwarded_host}"       => "//{$forwarded_host}",
-		);
+		];
+
+		//$new = str_replace( array_keys( $this->find_replace ), array_values( $this->find_replace ), $content );
+		$new = is_array( $content ) ? array_walk_recursive( $content, [ $this, 'replace_url' ] ) : str_replace( array_keys( $this->find_replace ), array_values( $this->find_replace ), $content );
+
+		return $new;
+	}
+
 
-		return str_replace( array_keys( $find_replace ), array_values( $find_replace ), $content );
+	/**
+	 * Replaces URL host within strings recursively.
+	 *
+	 * Required because the image srcset will use upload dir, which we don't filter
+	 *  (as we filter site URL), but does so before we filter site_URL.
+	 * BUT we can't filter upload dir directly, because then WP won't auto-detect protocol
+	 *  for us, as we'd be replacing the URL too soon.
+	 * So, we filter the srcset at the last minute.
+	 *
+	 * @since 1.0.0
+	 *
+	 * @param array $element the array to operate on
+	 * @param int $index the internal pointer for array_walk_recursive
+	 * @return array the updated array
+	 */
+	private function replace_url( &$element, $index ) {
+		return str_replace( array_keys( $this->find_replace ), array_values( $this->find_replace ), $element );
 	}