Skip to content

Commit 2e1836c

Browse files
authored
Run integration tests in Ubuntu 14.04 (#370)
The tests were disabled because we used to build the Cloud Bigtable Emulator from source, and Ubuntu 14.04 native golang tools could not do it. Now that we install the emulator via the Cloud SDK, this is no longer an issue. This fixes #361. Ignore testing components in code coverage reports.
1 parent 37c00f4 commit 2e1836c

2 files changed

Lines changed: 13 additions & 6 deletions

File tree

.codecov.yml

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,3 +14,14 @@ ignore:
1414
- "*.pb.h"
1515
# Ignore third party code and dependencies too.
1616
- "/third_party/**"
17+
# Ignore the bigtable/client/testing directory, because these are components
18+
# to drive testing, their coverage is not interesting.
19+
- "/bigtable/client/testing/**"
20+
# Ignore the bigtable/tests/ directory, because these are integration tests,
21+
# also used to drive testing and therefore their coverage is not interesting.
22+
- "/bigtable/tests/**"
23+
# Ignore the benchmarks, they are not important for the experience for our
24+
# users.
25+
- "/bigtable/benchmarks/**"
26+
# Also ignore the unit tests.
27+
- "**/*_test.cc$"

ci/build-docker.sh

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -74,12 +74,8 @@ echo "${COLOR_YELLOW}Finished build at: $(date)${COLOR_RESET}"
7474
# Run the tests and output any failures.
7575
CTEST_OUTPUT_ON_FAILURE=1 make -j ${NCPU} test
7676

77-
# If possible, run the integration tests.
78-
if [ -r /etc/lsb-release ] && grep -q 14.04 /etc/lsb-release; then
79-
echo "Skipping integration tests, Go version too old in Ubuntu 14.04."
80-
else
81-
(cd bigtable/tests && /v/bigtable/tests/run_integration_tests_emulator.sh)
82-
fi
77+
# Run the integration tests.
78+
(cd bigtable/tests && /v/bigtable/tests/run_integration_tests_emulator.sh)
8379

8480
# Some of the sanitizers only emit errors and do not change the error code
8581
# of the tests, find any such errors and report them as a build failure.

0 commit comments

Comments
 (0)