gnd: Add graph-node-style Ethereum validation (kind, address, block handlers)

Port Ethereum-specific validation from graph-node's DataSource::validate():
- Validate data source kind is 'ethereum' or 'ethereum/contract'
- Require source address when call or block handlers are present
- Enforce block handler constraints (no duplicates per filter type,
  no mixing non-filtered with polling/once)
- Validate receipt requires apiVersion >= 0.0.7
- Validate eth call declarations require specVersion >= 1.2.0

To support this, enrich gnd's simplified types: event_handlers now
carry receipt and call-decl flags, block_handlers carry filter kind.
These structural validations run during build (validate_manifest)
but not during codegen to avoid blocking code generation for
manifests with semantic issues.

Also fix codegen snapshot tests to use valid manifests (ABIs listed,
handlers defined) per validation added in previous commits.

Author: lutter

gnd/src/commands/codegen.rs

@@ -639,7 +639,12 @@ dataSources:
       file: ./mapping.ts
       entities:
         - MyEntity
-      abis: []
+      abis:
+        - name: TestContract
+          file: ./TestContract.json
+      eventHandlers:
+        - event: Transfer(address,address,uint256)
+          handler: handleTransfer
 "#;
         fs::write(project_dir.join("subgraph.yaml"), manifest_content).unwrap();
 
@@ -652,6 +657,7 @@ type MyEntity @entity(immutable: true) {
 "#;
         fs::write(project_dir.join("schema.graphql"), schema_content).unwrap();
         fs::write(project_dir.join("mapping.ts"), "").unwrap();
+        fs::write(project_dir.join("TestContract.json"), "[]").unwrap();
 
         // Run codegen
         let opt = CodegenOpt {
@@ -760,6 +766,9 @@ dataSources:
       abis:
         - name: ExampleContract
           file: ./Abi.json
+      eventHandlers:
+        - event: ExampleEvent(string)
+          handler: handleExampleEvent
 "#;
         fs::write(project_dir.join("subgraph.yaml"), manifest_content).unwrap();
 

gnd/src/manifest.rs

@@ -14,7 +14,7 @@ use graph::data_source::{
     UnresolvedDataSource as GraphUnresolvedDS, UnresolvedDataSourceTemplate as GraphUnresolvedDST,
 };
 use graph::prelude::DeploymentHash;
-use graph_chain_ethereum::Chain;
+use graph_chain_ethereum::{BlockHandlerFilter, Chain};
 use semver::Version;
 
 use crate::output::{step, Step};
@@ -68,12 +68,12 @@ pub struct DataSource {
     pub source_address: Option<String>,
     /// The ABI name referenced in `source.abi` (Ethereum data sources only).
     pub source_abi: Option<String>,
-    /// Event handler names from the mapping.
-    pub event_handlers: Vec<String>,
+    /// Event handlers from the mapping.
+    pub event_handlers: Vec<EventHandler>,
     /// Call handler names from the mapping.
     pub call_handlers: Vec<String>,
-    /// Block handler names from the mapping.
-    pub block_handlers: Vec<String>,
+    /// Block handlers from the mapping (with filter info for validation).
+    pub block_handlers: Vec<BlockHandler>,
 }
 
 impl DataSource {
@@ -94,12 +94,12 @@ pub struct Template {
     pub abis: Vec<Abi>,
     /// The ABI name referenced in `source.abi` (Ethereum templates only).
     pub source_abi: Option<String>,
-    /// Event handler names from the mapping.
-    pub event_handlers: Vec<String>,
+    /// Event handlers from the mapping.
+    pub event_handlers: Vec<EventHandler>,
     /// Call handler names from the mapping.
     pub call_handlers: Vec<String>,
-    /// Block handler names from the mapping.
-    pub block_handlers: Vec<String>,
+    /// Block handlers from the mapping (with filter info for validation).
+    pub block_handlers: Vec<BlockHandler>,
 }
 
 impl Manifest {
@@ -116,6 +116,31 @@ pub struct Abi {
     pub file: String,
 }
 
+/// An event handler with metadata needed for validation.
+#[derive(Debug)]
+pub struct EventHandler {
+    pub handler: String,
+    /// Whether this handler requires transaction receipts.
+    pub receipt: bool,
+    /// Whether this handler has eth call declarations.
+    pub has_call_decls: bool,
+}
+
+/// A block handler with filter info needed for validation.
+#[derive(Debug)]
+pub struct BlockHandler {
+    pub handler: String,
+    pub filter: Option<BlockHandlerFilterKind>,
+}
+
+/// The kind of filter on a block handler (simplified from graph-node's `BlockHandlerFilter`).
+#[derive(Debug, Clone, PartialEq, Eq)]
+pub enum BlockHandlerFilterKind {
+    Call,
+    Once,
+    Polling,
+}
+
 /// Load a subgraph manifest from a YAML file.
 ///
 /// This uses graph-node's `UnresolvedSubgraphManifest::parse()` which
@@ -197,7 +222,11 @@ fn convert_data_source(ds: GraphUnresolvedDS<Chain>) -> DataSource {
                 .mapping
                 .event_handlers
                 .iter()
-                .map(|h| h.handler.clone())
+                .map(|h| EventHandler {
+                    handler: h.handler.clone(),
+                    receipt: h.receipt,
+                    has_call_decls: !h.calls.raw_decls.is_empty(),
+                })
                 .collect(),
             call_handlers: eth
                 .mapping
@@ -209,7 +238,10 @@ fn convert_data_source(ds: GraphUnresolvedDS<Chain>) -> DataSource {
                 .mapping
                 .block_handlers
                 .iter()
-                .map(|h| h.handler.clone())
+                .map(|h| BlockHandler {
+                    handler: h.handler.clone(),
+                    filter: h.filter.as_ref().map(convert_block_handler_filter),
+                })
                 .collect(),
         },
         GraphUnresolvedDS::Subgraph(sub) => DataSource {
@@ -287,7 +319,11 @@ fn convert_template(t: GraphUnresolvedDST<Chain>) -> Template {
                 .mapping
                 .event_handlers
                 .iter()
-                .map(|h| h.handler.clone())
+                .map(|h| EventHandler {
+                    handler: h.handler.clone(),
+                    receipt: h.receipt,
+                    has_call_decls: !h.calls.raw_decls.is_empty(),
+                })
                 .collect(),
             call_handlers: eth
                 .mapping
@@ -299,7 +335,10 @@ fn convert_template(t: GraphUnresolvedDST<Chain>) -> Template {
                 .mapping
                 .block_handlers
                 .iter()
-                .map(|h| h.handler.clone())
+                .map(|h| BlockHandler {
+                    handler: h.handler.clone(),
+                    filter: h.filter.as_ref().map(convert_block_handler_filter),
+                })
                 .collect(),
         },
         GraphUnresolvedDST::Offchain(off) => Template {
@@ -339,6 +378,15 @@ fn convert_template(t: GraphUnresolvedDST<Chain>) -> Template {
     }
 }
 
+/// Convert a graph-node `BlockHandlerFilter` to gnd's simplified `BlockHandlerFilterKind`.
+fn convert_block_handler_filter(filter: &BlockHandlerFilter) -> BlockHandlerFilterKind {
+    match filter {
+        BlockHandlerFilter::Call => BlockHandlerFilterKind::Call,
+        BlockHandlerFilter::Once => BlockHandlerFilterKind::Once,
+        BlockHandlerFilter::Polling { .. } => BlockHandlerFilterKind::Polling,
+    }
+}
+
 /// Get the directory containing a manifest file.
 ///
 /// This handles the edge case where `manifest_path` is a bare filename