Refactor comment reply list to query all replies by default

- Change "comment reply list" from requiring commentName to optional
- Add --comment flag to filter replies by comment name
- Use Core API (ReplyV1alpha1Api.listReply) to query all replies
- Use Console API (ReplyV1alpha1ConsoleApi.listReplies) when --comment is provided
- Update printReplyList to handle both ReplyList and ListedReplyList types

Author: ruibaby

src/commands/comment/__test__/comment-entry.spec.ts

@@ -99,7 +99,18 @@ test("tryRunCommentCommand dispatches reply list subcommands", async () => {
 
   await expect(
     tryRunCommentCommand(
-      ["comment", "reply", "list", "comment-1", "--page", "2", "--size", "10", "--json"],
+      [
+        "comment",
+        "reply",
+        "list",
+        "--comment",
+        "comment-1",
+        "--page",
+        "2",
+        "--size",
+        "10",
+        "--json",
+      ],
       runtimeMock as never,
     ),
   ).resolves.toBe(true);

src/commands/comment/format.ts

@@ -4,6 +4,7 @@ import type {
   ListedReply,
   ListedReplyList,
   Reply,
+  ReplyList,
 } from "@halo-dev/api-client";
 import Table from "cli-table3";
 
@@ -166,22 +167,60 @@ export function printComment(comment: Comment, json = false): void {
   } as Record<string, unknown>);
 }
 
-export function printReplyList(list: ListedReplyList | ListedReply[], json = false): void {
+function formatReplyRow(
+  reply: Reply,
+  widths: number[],
+  ownerDisplayName?: string,
+): [string, string, string, string, string] {
+  return [
+    reply.metadata.name,
+    truncateDisplayText(ownerDisplayName ?? reply.spec.owner?.displayName ?? "", widths[1]!),
+    truncateDisplayText(stripHtmlTags(reply.spec.content), widths[2]!),
+    reply.spec.approved ? "yes" : "no",
+    formatTimestamp(reply.metadata.creationTimestamp ?? undefined),
+  ];
+}
+
+export function printReplyList(
+  list: ListedReplyList | ListedReply[] | ReplyList,
+  json = false,
+): void {
   if (json) {
     printJson(list);
     return;
   }
 
+  const widths = getReplyListWidths();
+
+  // Handle ReplyList from Core API (listReply)
+  if (
+    !Array.isArray(list) &&
+    "items" in list &&
+    list.items.length > 0 &&
+    !("reply" in list.items[0]!)
+  ) {
+    const replyList = list as ReplyList;
+    const rows = replyList.items.map((reply) => formatReplyRow(reply, widths));
+
+    printTable(["NAME", "OWNER", "CONTENT", "APPROVED", "CREATED AT"], rows, widths);
+    printPaginationFooter({
+      page: replyList.page,
+      size: replyList.size,
+      total: replyList.total,
+      totalPages: replyList.totalPages,
+      hasNext: replyList.hasNext,
+      hasPrevious: replyList.hasPrevious,
+      itemLabel: "reply",
+    });
+    return;
+  }
+
+  // Handle ListedReplyList from Console API (listReplies)
   const items = Array.isArray(list) ? list : list.items;
   const total = Array.isArray(list) ? list.length : list.total;
-  const widths = getReplyListWidths();
-  const rows = items.map((item) => [
-    item.reply.metadata.name,
-    truncateDisplayText(resolveCommentOwnerName(item), widths[1]!),
-    truncateDisplayText(stripHtmlTags(item.reply.spec.content), widths[2]!),
-    item.reply.spec.approved ? "yes" : "no",
-    formatTimestamp(item.reply.metadata.creationTimestamp ?? undefined),
-  ]);
+  const rows = (items as ListedReply[]).map((item) =>
+    formatReplyRow(item.reply, widths, item.owner?.displayName),
+  );
 
   printTable(["NAME", "OWNER", "CONTENT", "APPROVED", "CREATED AT"], rows, widths);
 

src/commands/comment/index.ts

@@ -218,7 +218,8 @@ function buildCommentCli(runtime: RuntimeContext): CAC {
     (bin) =>
       `${bin} create-reply comment-abc123 --content "Thanks for your feedback" --quote-reply reply-abc123`,
   );
-  commentCli.example((bin) => `${bin} reply list comment-abc123`);
+  commentCli.example((bin) => `${bin} reply list`);
+  commentCli.example((bin) => `${bin} reply list --comment comment-abc123`);
   commentCli.help();
 
   return commentCli;

src/commands/comment/reply.ts

@@ -23,6 +23,7 @@ interface CommentDeleteOptions extends CommentCommandOptions {
 interface ReplyListOptions extends CommentCommandOptions {
   page?: string;
   size?: string;
+  comment?: string;
 }
 
 export function buildApprovePatch(): JsonPatchInner[] {
@@ -44,24 +45,37 @@ export function buildReplyCli(runtime: RuntimeContext): CAC {
   const replyCli = cac("halo comment reply");
 
   replyCli
-    .command("list <commentName>", "List replies for a comment")
+    .command("list", "List replies")
     .option("--profile <name>", "Halo profile name")
     .option("--json", "Output JSON")
-    .option("--page <number>", "Page number")
-    .option("--size <number>", "Page size")
-    .action(async (commentName: string, options: ReplyListOptions) => {
+    .option("--page <number>", "Page number", { default: 1 })
+    .option("--size <number>", "Page size", { default: 20 })
+    .option("--comment <name>", "Filter by comment name")
+    .action(async (options: ReplyListOptions) => {
       const { profile, clients } = await runtime.getClientsForOptions(options);
-      const replyConsoleApi = new ReplyV1alpha1ConsoleApi(
-        undefined,
-        profile.baseUrl,
-        clients.axios,
-      );
-      const response = await replyConsoleApi.listReplies({
-        commentName,
-        page: parseNumberOption(options.page),
-        size: parseNumberOption(options.size),
-      });
-      printReplyList(response.data, options.json);
+
+      if (options.comment) {
+        // Use Console API to list replies for a specific comment
+        const replyConsoleApi = new ReplyV1alpha1ConsoleApi(
+          undefined,
+          profile.baseUrl,
+          clients.axios,
+        );
+        const response = await replyConsoleApi.listReplies({
+          commentName: options.comment,
+          page: parseNumberOption(options.page),
+          size: parseNumberOption(options.size),
+        });
+        printReplyList(response.data, options.json);
+      } else {
+        // Use Core API to list all replies
+        const replyApi = new ReplyV1alpha1Api(undefined, profile.baseUrl, clients.axios);
+        const response = await replyApi.listReply({
+          page: parseNumberOption(options.page),
+          size: parseNumberOption(options.size),
+        });
+        printReplyList(response.data, options.json);
+      }
     });
 
   replyCli
@@ -124,7 +138,8 @@ export function buildReplyCli(runtime: RuntimeContext): CAC {
     });
 
   replyCli.usage("<command> [flags]");
-  replyCli.example((bin) => `${bin} list comment-abc123`);
+  replyCli.example((bin) => `${bin} list`);
+  replyCli.example((bin) => `${bin} list --comment comment-abc123`);
   replyCli.example((bin) => `${bin} get reply-abc123`);
   replyCli.example((bin) => `${bin} approve reply-abc123`);
   replyCli.example((bin) => `${bin} delete reply-abc123 --force`);