Add --app-id flag to plugin install for App Store installation

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: ruibaby

src/commands/moment/index.ts

@@ -62,7 +62,7 @@ async function ensureMomentsPluginInstalled(clients: HaloClients): Promise<void>
     }
     if (axios.isAxiosError(error) && error.response?.status === 404) {
       throw new CliError(
-        `The ${MOMENTS_PLUGIN_NAME} plugin is not installed. Install it from the App Store or via: halo plugin install`,
+        `The ${MOMENTS_PLUGIN_NAME} plugin is not installed. Install it from the App Store with: halo plugin install --app-id app-SnwWD`,
       );
     }
     throw error;

src/commands/plugin/__test__/plugin.spec.ts

@@ -15,26 +15,39 @@ afterEach(() => {
 
 test("resolvePluginInstallSource accepts urls", () => {
   expect(resolvePluginInstallSource({ url: " https://example.com/plugin.jar " })).toEqual({
+    kind: "url",
     url: "https://example.com/plugin.jar",
-    file: undefined,
   });
 });
 
 test("resolvePluginInstallSource accepts files", () => {
   expect(resolvePluginInstallSource({ file: " ./plugin.jar " })).toEqual({
-    url: undefined,
+    kind: "file",
     file: "./plugin.jar",
   });
 });
 
+test("resolvePluginInstallSource accepts app-id", () => {
+  expect(resolvePluginInstallSource({ appId: " app-SnwWD " })).toEqual({
+    kind: "app-store",
+    appId: "app-SnwWD",
+  });
+});
+
 test("resolvePluginInstallSource requires exactly one source", () => {
-  expect(() => resolvePluginInstallSource({})).toThrow(/Provide either --url or --file/);
+  expect(() => resolvePluginInstallSource({})).toThrow(/Provide exactly one install source/);
   expect(() =>
     resolvePluginInstallSource({
       url: "https://example.com/plugin.jar",
       file: "./plugin.jar",
     }),
-  ).toThrow(/Use only one plugin source/);
+  ).toThrow(/Use only one plugin install source/);
+  expect(() =>
+    resolvePluginInstallSource({
+      url: "https://example.com/plugin.jar",
+      appId: "app-SnwWD",
+    }),
+  ).toThrow(/Use only one plugin install source/);
 });
 
 test("confirmPluginMutation skips prompting with --force", async () => {

src/commands/plugin/index.ts

@@ -32,6 +32,7 @@ interface PluginCommandOptions {
   enabled?: string;
   url?: string;
   file?: string;
+  appId?: string;
   online?: boolean;
   all?: boolean;
   yes?: boolean;
@@ -190,22 +191,35 @@ function createSpinnerReporter(json = false): SpinnerReporter {
   return new SpinnerReporter(process.stdout.isTTY && !json);
 }
 
-export function resolvePluginInstallSource(options: PluginCommandOptions): {
-  url?: string;
-  file?: string;
-} {
+export type PluginInstallSource =
+  | { kind: "url"; url: string }
+  | { kind: "file"; file: string }
+  | { kind: "app-store"; appId: string };
+
+export function resolvePluginInstallSource(options: PluginCommandOptions): PluginInstallSource {
   const url = options.url?.trim();
   const file = options.file?.trim();
+  const appId = options.appId?.trim();
+
+  const sourceCount = Number(Boolean(url)) + Number(Boolean(file)) + Number(Boolean(appId));
+
+  if (sourceCount === 0) {
+    throw new CliError("Provide exactly one install source: --url, --file, or --app-id.");
+  }
+
+  if (sourceCount > 1) {
+    throw new CliError("Use only one plugin install source: --url, --file, or --app-id.");
+  }
 
-  if (!url && !file) {
-    throw new CliError("Provide either --url or --file.");
+  if (url) {
+    return { kind: "url", url };
   }
 
-  if (url && file) {
-    throw new CliError("Use only one plugin source: --url or --file.");
+  if (file) {
+    return { kind: "file", file };
   }
 
-  return { url, file };
+  return { kind: "app-store", appId: appId! };
 }
 
 function getPluginMutationVerb(action: "enable" | "disable" | "uninstall"): string {
@@ -669,15 +683,17 @@ function buildPluginCli(runtime: RuntimeContext): CAC {
     .option("--json", "Output JSON")
     .option("--url <url>", "Remote JAR URL")
     .option("--file <path>", "Local JAR file path")
-    .option("-y, --yes", "Skip third-party URL confirmation")
+    .option("--app-id <id>", "Halo App Store application ID")
+    .option("-y, --yes", "Skip confirmation prompts")
     .action(async (options: PluginCommandOptions) => {
       if (options.online) {
-        throw new CliError("`halo plugin install` does not support --online. Use --url or --file.");
+        throw new CliError("`halo plugin install` does not support --online. Use --app-id.");
       }
 
       const source = resolvePluginInstallSource(options);
+
       if (
-        source.url &&
+        source.kind === "url" &&
         !(await confirmThirdPartyPackageSource(
           source.url,
           {
@@ -691,20 +707,54 @@ function buildPluginCli(runtime: RuntimeContext): CAC {
       }
 
       const { clients } = await runtime.getClientsForOptions(options);
-      const response = source.url
-        ? await clients.console.plugin.plugin.installPluginFromUri({
+      const spinner = createSpinnerReporter(options.json);
+      let response;
+
+      try {
+        if (source.kind === "url") {
+          spinner.start("Installing plugin from remote URL...");
+          response = await clients.console.plugin.plugin.installPluginFromUri({
             installFromUriRequest: { uri: source.url },
-          })
-        : await clients.console.plugin.plugin.installPlugin({
-            file: await loadFileAsJar(source.file!),
           });
+          spinner.succeed(`Installed plugin ${response.data.metadata.name}.`);
+        } else if (source.kind === "file") {
+          spinner.start("Uploading local plugin package...");
+          response = await clients.console.plugin.plugin.installPlugin({
+            file: await loadFileAsJar(source.file),
+          });
+          spinner.succeed(`Installed plugin ${response.data.metadata.name}.`);
+        } else {
+          spinner.start(`Resolving App Store package for ${source.appId}...`);
+          const appStoreClient = await createAppStoreClient(clients);
+          const release = await resolveLatestAppStoreRelease(appStoreClient, source.appId);
+          spinner.stop();
+
+          const confirmed = await confirmAppStoreReleaseReview(
+            {
+              commandPath: "halo plugin install",
+              actionLabel: `installing plugin from App Store`,
+              items: [{ name: source.appId, releaseUrl: release.releaseUrl }],
+            },
+            options,
+          );
+
+          if (!confirmed) {
+            return;
+          }
+
+          spinner.start(`Installing plugin ${source.appId} from Halo App Store...`);
+          response = await clients.console.plugin.plugin.installPluginFromUri({
+            installFromUriRequest: { uri: release.downloadUrl },
+          });
+          spinner.succeed(`Installed plugin ${response.data.metadata.name}.`);
+        }
+      } finally {
+        spinner.stop();
+      }
 
       if (options.json) {
         printJson(response.data);
-        return;
       }
-
-      process.stdout.write(`Installed plugin ${response.data.metadata.name}.\n`);
     });
 
   pluginCli
@@ -818,6 +868,7 @@ function buildPluginCli(runtime: RuntimeContext): CAC {
   pluginCli.example((bin) => `${bin} disable PluginName --force`);
   pluginCli.example((bin) => `${bin} uninstall PluginName --force`);
   pluginCli.example((bin) => `${bin} install --url https://example.com/plugin.jar`);
+  pluginCli.example((bin) => `${bin} install --app-id app-SnwWD`);
   pluginCli.example((bin) => `${bin} upgrade PluginName --online`);
   pluginCli.example((bin) => `${bin} upgrade --all --online --yes`);
   pluginCli.help();