Skip to content

Commit 07cc691

Browse files
committed
Simplify strategy labeling
1 parent 6772e7f commit 07cc691

5 files changed

Lines changed: 6 additions & 12 deletions

File tree

app/web/api/v1/strategies.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ def index(_request)
3333

3434
def display_name_for(name)
3535
case name.to_s
36-
when 'faraday' then 'Standard rendering'
36+
when 'faraday' then 'Default'
3737
when 'browserless' then 'JavaScript pages (recommended)'
3838
else name.to_s.split('_').map(&:capitalize).join(' ')
3939
end

app/web/boot/setup.rb

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -7,12 +7,11 @@ module Boot
77
# Applies boot-time runtime configuration outside the Roda class body.
88
module Setup
99
class << self
10-
# Validates environment configuration and wires the request service.
10+
# Validates environment configuration.
1111
#
1212
# @return [void]
1313
def call!
1414
validate_environment!
15-
configure_request_service!
1615
end
1716

1817
private
@@ -23,11 +22,6 @@ def validate_environment!
2322
EnvironmentValidator.validate_production_security!
2423
Flags.validate!
2524
end
26-
27-
# @return [void]
28-
def configure_request_service!
29-
nil
30-
end
3125
end
3226
end
3327
end

frontend/src/__tests__/App.test.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ describe('App', () => {
7979

8080
mockUseStrategies.mockReturnValue({
8181
strategies: [
82-
{ id: 'faraday', name: 'faraday', display_name: 'Standard rendering' },
82+
{ id: 'faraday', name: 'faraday', display_name: 'Default' },
8383
{ id: 'browserless', name: 'browserless', display_name: 'JavaScript pages (recommended)' },
8484
],
8585
isLoading: false,
@@ -114,7 +114,7 @@ describe('App', () => {
114114

115115
it('falls back to the first available strategy when browserless is unavailable', () => {
116116
mockUseStrategies.mockReturnValue({
117-
strategies: [{ id: 'faraday', name: 'faraday', display_name: 'Standard rendering' }],
117+
strategies: [{ id: 'faraday', name: 'faraday', display_name: 'Default' }],
118118
isLoading: false,
119119
error: null,
120120
});

frontend/src/__tests__/mocks/server.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ export const server = setupServer(
2929
{
3030
id: 'faraday',
3131
name: 'faraday',
32-
display_name: 'Standard rendering',
32+
display_name: 'Default',
3333
},
3434
{
3535
id: 'browserless',

frontend/src/components/AppPanels.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ export function CreateFeedPanel({
7171
const urlInputRef = useRef<HTMLInputElement | null>(null);
7272
const tokenInputRef = useRef<HTMLInputElement | null>(null);
7373
const strategyOptionLabel = (strategy: Strategy) => {
74-
if (strategy.id === 'faraday') return 'Standard rendering';
74+
if (strategy.id === 'faraday') return 'Default';
7575
if (strategy.id === 'browserless') return 'JavaScript pages (recommended)';
7676
return strategy.display_name;
7777
};

0 commit comments

Comments
 (0)