clean unreloader setup

Author: gildesmarais

Gemfile

@@ -17,14 +17,14 @@ gem 'parallel'
 gem 'rack-attack'
 gem 'rack-cache'
 gem 'rack-timeout'
-gem 'rack-unreloader'
 gem 'roda'
 gem 'ssrf_filter'
 
 gem 'puma', require: false
 
 group :development do
   gem 'byebug'
+  gem 'rack-unreloader'
   gem 'rake', require: false
   gem 'rubocop', require: false
   gem 'rubocop-performance', require: false

app.rb

@@ -80,9 +80,6 @@ def fallback_html
           </html>
         HTML
       end
-
-      # Load all helper files
-      Dir['helpers/*.rb'].each { |f| require_relative f }
     end
   end
 end

config.ru

@@ -23,34 +23,40 @@ require_relative 'config/rack_attack'
 use Rack::Attack
 
 dev = ENV.fetch('RACK_ENV', nil) == 'development'
-app_requires = Dir['app/**/*.rb']
-route_requires = Dir['routes/**/*.rb']
-helper_requires = Dir['helpers/**/*.rb']
 
 if dev
   require 'logger'
+  require 'rack/unreloader'
+
   logger = Logger.new($stdout)
+  logger.level = Logger::INFO
+
+  # Simple Unreloader configuration following official docs
+  Unreloader = Rack::Unreloader.new(
+    subclasses: %w[Roda Html2rss],
+    logger: logger,
+    reload: true
+  ) do
+    Html2rss::Web::App
+  end
 
-  require 'rack/unreloader'
-  Unreloader = Rack::Unreloader.new(subclasses: %w[Roda Html2rss],
-                                    logger:,
-                                    reload: dev) do
-                                      Html2rss::Web::App
-                                    end
+  # Load main app file
   Unreloader.require('app.rb') { 'Html2rss::Web::App' }
 
-  app_requires.each { |f| Unreloader.require(f) }
-  route_requires.each { |f| Unreloader.require(f) }
-  helper_requires.each { |f| Unreloader.require(f) }
+  # Load all directories - Unreloader handles the rest
+  Unreloader.require('helpers')
+  Unreloader.require('app')
+  Unreloader.require('routes')
 
   run Unreloader
 else
   use Rack::Timeout
 
+  # Production: load everything upfront for better performance
   require_relative 'app'
-  app_requires.each { |f| require_relative f }
-  route_requires.each { |f| require_relative f }
-  helper_requires.each { |f| require_relative f }
+  Dir['app/**/*.rb'].each { |f| require_relative f }
+  Dir['routes/**/*.rb'].each { |f| require_relative f }
+  Dir['helpers/**/*.rb'].each { |f| require_relative f }
 
   run(Html2rss::Web::App.freeze.app)
 end

routes/app.rb

@@ -18,7 +18,7 @@ def self.load_routes(app)
       def self.load_api_routes(app)
         app.hash_branch 'api' do |r|
           r.response['Content-Type'] = 'application/json'
-          load_api_endpoints(r)
+          Html2rss::Web::AppRoutes.load_api_endpoints(r)
         end
       end
 
@@ -38,33 +38,33 @@ def self.load_feeds_endpoint(router)
       def self.load_strategies_endpoint(router)
         router.on 'strategies.json' do
           router.response['Cache-Control'] = 'public, max-age=3600'
-          JSON.generate(ApiRoutes.list_available_strategies)
+          JSON.generate(Html2rss::Web::ApiRoutes.list_available_strategies)
         end
       end
 
       def self.load_feed_generation_endpoint(router)
         router.on String do |feed_name|
-          ApiRoutes.handle_feed_generation(router, feed_name)
+          Html2rss::Web::ApiRoutes.handle_feed_generation(router, feed_name)
         end
       end
 
       def self.load_feed_routes(app)
         app.hash_branch 'feeds' do |r|
           r.on String do |feed_id|
-            AutoSourceRoutes.handle_stable_feed(r, feed_id)
+            Html2rss::Web::AutoSourceRoutes.handle_stable_feed(r, feed_id)
           end
         end
       end
 
       def self.load_auto_source_routes(app)
         app.hash_branch 'auto_source' do |r|
-          AutoSourceRoutes.handle_auto_source_routes(r)
+          Html2rss::Web::AutoSourceRoutes.handle_auto_source_routes(r)
         end
       end
 
       def self.load_health_check_routes(app)
         app.hash_branch 'health_check.txt' do |r|
-          HealthCheckRoutes.handle_health_check_routes(r)
+          Html2rss::Web::HealthCheckRoutes.handle_health_check_routes(r)
         end
       end
     end

spec/html2rss/web/app_integration_spec.rb

@@ -200,7 +200,7 @@
         get "/feeds/#{feed_id}?token=valid-token"
 
         expect(last_response.status).to eq(400)
-        expect(last_response.body).to include('URL parameter required')
+        expect(last_response.body).to include('url parameter required')
       end
     end
   end