Skip to content

Commit 1bd9113

Browse files
committed
ci: add frontend guardrail checks
1 parent 02f99ab commit 1bd9113

3 files changed

Lines changed: 10 additions & 6 deletions

File tree

.github/workflows/ci.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -88,6 +88,9 @@ jobs:
8888
- name: Verify generated OpenAPI client is up to date
8989
run: npm run openapi:verify
9090

91+
- name: Typecheck frontend
92+
run: npm run typecheck
93+
9194
- name: Check formatting
9295
run: npm run format:check
9396

Makefile

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# frozen_string_literal: true
22

3-
.PHONY: help test lint lint-js lint-ruby lintfix lintfix-js lintfix-ruby setup dev clean frontend-setup quick-check ready yard-verify-public-docs openapi openapi-verify openapi-client openapi-client-verify openapi-lint openapi-lint-redocly openapi-lint-spectral openai-lint-spectral
3+
.PHONY: help test lint lint-js lint-ruby lintfix lintfix-js lintfix-ruby setup dev clean frontend-setup check-frontend quick-check ready yard-verify-public-docs openapi openapi-verify openapi-client openapi-client-verify openapi-lint openapi-lint-redocly openapi-lint-spectral openai-lint-spectral
44

55
# Default target
66
help: ## Show this help message
@@ -47,6 +47,10 @@ test-frontend-unit: ## Run frontend unit tests only
4747
test-frontend-contract: ## Run frontend contract tests only
4848
@cd frontend && npm run test:contract
4949

50+
check-frontend: ## Run frontend typecheck, format, and test checks
51+
$(MAKE) lint-js
52+
$(MAKE) test-frontend
53+
5054

5155
lint: lint-ruby lint-js ## Run all linters (Ruby + Frontend) - errors when issues found
5256
@echo "All linting complete!"

frontend/src/styles/main.css

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -52,11 +52,8 @@
5252
html {
5353
background:
5454
radial-gradient(circle at top left, rgba(255, 255, 255, 0.05), transparent 24rem),
55-
linear-gradient(180deg, rgba(255, 255, 255, 0.015), transparent 18rem),
56-
var(--bg-page);
57-
background-size:
58-
auto,
59-
auto;
55+
linear-gradient(180deg, rgba(255, 255, 255, 0.015), transparent 18rem), var(--bg-page);
56+
background-size: auto, auto;
6057
}
6158

6259
body {

0 commit comments

Comments
 (0)