Skip to content

Commit 1e5f54c

Browse files
committed
refactor: improve utility menu labels and order
1 parent 77a7368 commit 1e5f54c

2 files changed

Lines changed: 17 additions & 9 deletions

File tree

frontend/src/__tests__/App.test.tsx

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -369,16 +369,24 @@ describe('App', () => {
369369
expect(bookmarklet.getAttribute('href')).not.toContain('%27+encodeURIComponent');
370370
});
371371

372-
it('shows the OpenAPI spec and included-config links in the more menu', () => {
372+
it('shows the utility links in a user-focused order', () => {
373373
render(<App />);
374374

375375
fireEvent.click(screen.getByRole('button', { name: 'More' }));
376376

377+
const utilityLinks = screen.getAllByRole('link').map((link) => link.textContent);
378+
expect(utilityLinks).toEqual([
379+
'Try included feeds',
380+
'Bookmarklet',
381+
'OpenAPI spec',
382+
'Source code',
383+
]);
384+
377385
expect(screen.getByRole('link', { name: 'OpenAPI spec' })).toHaveAttribute(
378386
'href',
379387
'http://example.test/openapi.yaml'
380388
);
381-
expect(screen.getByRole('link', { name: 'Included configs' })).toHaveAttribute(
389+
expect(screen.getByRole('link', { name: 'Try included feeds' })).toHaveAttribute(
382390
'href',
383391
'https://html2rss.github.io/web-application/how-to/use-included-configs/'
384392
);

frontend/src/components/AppPanels.tsx

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -270,20 +270,20 @@ export function UtilityStrip({
270270
</button>
271271
{isOpen && (
272272
<div class="utility-strip__items">
273-
<Bookmarklet />
274-
{openapiUrl && (
275-
<a href={openapiUrl} target="_blank" rel="noopener noreferrer" class="utility-link">
276-
OpenAPI spec
277-
</a>
278-
)}
279273
<a
280274
href="https://html2rss.github.io/web-application/how-to/use-included-configs/"
281275
target="_blank"
282276
rel="noopener noreferrer"
283277
class="utility-link"
284278
>
285-
Included configs
279+
Try included feeds
286280
</a>
281+
<Bookmarklet />
282+
{openapiUrl && (
283+
<a href={openapiUrl} target="_blank" rel="noopener noreferrer" class="utility-link">
284+
OpenAPI spec
285+
</a>
286+
)}
287287
<a
288288
href="https://github.com/html2rss/html2rss-web"
289289
target="_blank"

0 commit comments

Comments
 (0)