Consolidate structured log emission

Author: gildesmarais

app/web/security/security_logger.rb

@@ -10,16 +10,10 @@ module Web
     # Provides structured logging for security events to stdout
     module SecurityLogger
       class << self
-        # Initialize logger to stdout with structured JSON output
-        # @return [Logger]
-        def logger
-          Thread.current[:security_logger] ||= create_logger
-        end
-
-        # Reset logger (for testing)
+        # Reset shared logger state for tests.
         # @return [void]
         def reset_logger!
-          Thread.current[:security_logger] = nil
+          AppLogger.reset_logger!
         end
 
         ##
@@ -133,23 +127,18 @@ def log_cache_lifecycle(component, event, details = {})
 
         private
 
-        def create_logger
-          AppLogger.logger
-        end
-
         ##
         # Log a security event
         # @param event_type [String] type of security event
         # @param data [Hash] event data
         def log_event(event_type, data, severity: :warn)
-          context_data = RequestContext.current_h
-          payload = {
-            security_event: event_type,
-            **context_data,
-            **LogSanitizer.sanitize_details(data)
-          }.to_json
-
-          logger.public_send(severity, payload)
+          LogEvent.emit(
+            level: severity,
+            payload: {
+              security_event: event_type,
+              **data
+            }
+          )
         rescue StandardError => error
           handle_logging_error(error, event_type, data)
         end

app/web/telemetry/log_event.rb

@@ -0,0 +1,31 @@
+# frozen_string_literal: true
+
+module Html2rss
+  module Web
+    ##
+    # Shared structured log emitter for request-scoped application events.
+    module LogEvent
+      class << self
+        # @param payload [Hash{Symbol=>Object}]
+        # @param level [Symbol]
+        # @return [void]
+        def emit(payload:, level: :info)
+          logger.public_send(level, build_payload(payload).to_json)
+        end
+
+        private
+
+        # @return [Logger]
+        def logger
+          AppLogger.logger
+        end
+
+        # @param payload [Hash{Symbol=>Object}]
+        # @return [Hash{Symbol=>Object}]
+        def build_payload(payload)
+          RequestContext.current_h.merge(LogSanitizer.sanitize_details(payload))
+        end
+      end
+    end
+  end
+end

app/web/telemetry/observability.rb

@@ -14,18 +14,13 @@ class << self
         # @param level [Symbol]
         # @return [void]
         def emit(event_name:, outcome:, details: {}, level: :info)
-          logger.public_send(level, build_payload(event_name, outcome, details).to_json)
+          LogEvent.emit(payload: build_payload(event_name, outcome, details), level: level)
         rescue StandardError => error
           handle_emit_error(error, event_name, outcome)
         end
 
         private
 
-        # @return [Logger]
-        def logger
-          AppLogger.logger
-        end
-
         # @param error [StandardError]
         # @param event_name [String]
         # @param outcome [String]
@@ -41,7 +36,7 @@ def handle_emit_error(error, event_name, outcome)
         # @return [Hash{Symbol=>Object}]
         def build_payload(event_name, outcome, details)
           context = RequestContext.current_h
-          base_payload(event_name, outcome, context).merge(details: LogSanitizer.sanitize_details(details))
+          base_payload(event_name, outcome, context).merge(details: details)
         end
 
         # @param event_name [String]

spec/html2rss/web/log_sanitizer_spec.rb

@@ -6,6 +6,7 @@
 require_relative '../../../app/web/request/request_context'
 require_relative '../../../app/web/security/security_logger'
 require_relative '../../../app/web/telemetry/app_logger'
+require_relative '../../../app/web/telemetry/log_event'
 require_relative '../../../app/web/telemetry/log_sanitizer'
 require_relative '../../../app/web/telemetry/observability'
 
@@ -29,8 +30,6 @@
     Html2rss::Web::AppLogger.reset_logger!
     Html2rss::Web::SecurityLogger.reset_logger!
     allow(Html2rss::Web::AppLogger).to receive(:logger).and_return(logger)
-    allow(Html2rss::Web::SecurityLogger).to receive(:logger).and_return(logger)
-    allow(Html2rss::Web::Observability).to receive(:logger).and_return(logger)
   end
 
   after do