Skip to content

Commit 2e4c81c

Browse files
committed
chore: drop accidental typecheck gate changes
1 parent 867b62d commit 2e4c81c

7 files changed

Lines changed: 25 additions & 37 deletions

File tree

Makefile

Lines changed: 4 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# frozen_string_literal: true
22

3-
.PHONY: help test lint lint-js lint-ruby lintfix lintfix-js lintfix-ruby setup dev clean frontend-setup quick-check ready yard-verify-public-docs openapi openapi-verify openapi-client openapi-client-verify openapi-lint openapi-lint-redocly openapi-lint-spectral openai-lint-spectral
3+
.PHONY: help test lint lint-js lint-ruby lintfix lintfix-js lintfix-ruby setup dev clean frontend-setup ready yard-verify-public-docs openapi openapi-verify openapi-client openapi-client-verify openapi-lint openapi-lint-redocly openapi-lint-spectral openai-lint-spectral
44

55
# Default target
66
help: ## Show this help message
@@ -59,8 +59,6 @@ lint-ruby: ## Run Ruby linter (RuboCop) - errors when issues found
5959
@echo "Ruby linting complete!"
6060

6161
lint-js: ## Run JavaScript/Frontend linter (Prettier) - errors when issues found
62-
@echo "Running TypeScript typecheck..."
63-
@cd frontend && npm run typecheck
6462
@echo "Running Prettier format check..."
6563
@cd frontend && npm run format:check
6664
@echo "JavaScript linting complete!"
@@ -78,15 +76,10 @@ lintfix-js: ## Auto-fix JavaScript/Frontend linting issues
7876
@cd frontend && npm run format
7977
@echo "JavaScript lintfix complete!"
8078

81-
quick-check: ## Fast local checks (Ruby lint/docs + frontend format/typecheck)
82-
@echo "Running quick checks..."
83-
$(MAKE) lint-ruby
84-
$(MAKE) lint-js
85-
@echo "Quick checks complete!"
86-
87-
ready: ## Pre-commit gate (quick checks + RSpec)
79+
ready: ## Pre-commit gate (RuboCop + RSpec)
8880
@echo "Running pre-commit checks..."
89-
$(MAKE) quick-check
81+
bundle exec rubocop -F
82+
bundle exec rake yard:verify_public_docs
9083
bundle exec rspec
9184
@echo "Pre-commit checks complete!"
9285

frontend/.prettierignore

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,3 @@
11
# Frontend package files
22
package-lock.json
33
yarn.lock
4-
5-
# Generated and transient frontend output
6-
.astro/
7-
test-results/
8-
src/api/generated/

frontend/package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010
"preview": "vite preview --port 4001 --host",
1111
"format": "prettier --write .",
1212
"format:check": "prettier --check .",
13-
"typecheck": "tsc -p tsconfig.typecheck.json --noEmit",
1413
"openapi:generate": "openapi-ts -i ../docs/api/v1/openapi.yaml -o src/api/generated -c @hey-api/client-fetch",
1514
"openapi:verify": "npm run openapi:generate && git diff --exit-code -- src/api/generated",
1615
"test": "vitest",

frontend/src/env.d.ts

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1 +1,6 @@
11
/// <reference types="vite/client" />
2+
3+
declare module '*.module.css' {
4+
const classes: Record<string, string>;
5+
export default classes;
6+
}

frontend/src/hooks/useFeedConversion.ts

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { useState } from 'preact/hooks';
22
import { createFeed } from '../api/generated';
3-
import { apiClient } from '../api/client';
3+
import { apiClient, bearerHeaders } from '../api/client';
44
import type { FeedRecord } from '../api/contracts';
55

66
interface ConversionState {
@@ -32,20 +32,22 @@ export function useFeedConversion() {
3232
const response = await createFeed({
3333
client: apiClient,
3434
headers: {
35-
Authorization: `Bearer ${token}`,
35+
'Content-Type': 'application/json',
36+
...bearerHeaders(token),
3637
},
3738
body: {
3839
url: url.trim(),
3940
strategy: strategy.trim(),
4041
},
42+
responseStyle: 'data',
4143
throwOnError: true,
4244
});
4345

44-
if (!response.data?.success || !response.data.data?.feed) {
46+
if (!response?.success || !response.data?.feed) {
4547
throw new Error('Invalid response format');
4648
}
4749

48-
const result = response.data.data.feed;
50+
const result = response.data.feed;
4951
setState((prev) => ({ ...prev, isConverting: false, result, error: null }));
5052
} catch (error) {
5153
setState((prev) => ({
@@ -87,8 +89,7 @@ const toErrorMessage = (error: unknown): string => {
8789
const extractMessage = (error: unknown): string | null => {
8890
if (!error || typeof error !== 'object') return null;
8991

90-
const candidate =
91-
(error as { error?: { message?: unknown }; message?: unknown }).error?.message ??
92+
const candidate = (error as { error?: { message?: unknown }; message?: unknown }).error?.message ??
9293
(error as { message?: unknown }).message;
9394

9495
return typeof candidate === 'string' && candidate.trim() ? candidate : null;

frontend/src/hooks/useStrategies.ts

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -29,18 +29,20 @@ export function useStrategies(token: string | null) {
2929
client: apiClient,
3030
headers: {
3131
...bearerHeaders(token),
32+
'Content-Type': 'application/json',
3233
},
34+
responseStyle: 'data',
3335
});
3436

35-
if (response.error || !response.data?.success || !response.data.data?.strategies) {
37+
if (response?.success && response.data?.strategies) {
38+
setState({
39+
strategies: response.data.strategies,
40+
isLoading: false,
41+
error: null,
42+
});
43+
} else {
3644
throw new Error('Invalid response format from strategies API');
3745
}
38-
39-
setState({
40-
strategies: response.data.data.strategies,
41-
isLoading: false,
42-
error: null,
43-
});
4446
} catch (error) {
4547
setState({
4648
strategies: [],

frontend/tsconfig.typecheck.json

Lines changed: 0 additions & 7 deletions
This file was deleted.

0 commit comments

Comments
 (0)