fix: harden feed creation contracts

Author: gildesmarais

frontend/src/__tests__/App.contract.test.tsx

@@ -122,4 +122,29 @@ describe('App contract', () => {
 
     expect(screen.getByText('Invalid response format from API metadata')).toBeInTheDocument();
   });
+
+  it('reopens token recovery when a saved token is rejected by /api/v1/feeds', async () => {
+    authenticate();
+
+    server.use(
+      http.post('/api/v1/feeds', async () =>
+        HttpResponse.json({ success: false, error: { message: 'Unauthorized' } }, { status: 401 })
+      )
+    );
+
+    render(<App />);
+
+    await screen.findByLabelText('Page URL');
+
+    fireEvent.input(screen.getByLabelText('Page URL'), {
+      target: { value: 'https://example.com/articles' },
+    });
+    fireEvent.click(screen.getByRole('button', { name: 'Generate feed URL' }));
+
+    await screen.findByText('Access token was rejected. Paste a valid token to continue.');
+
+    expect(screen.getByText('Add access token')).toBeInTheDocument();
+    expect(screen.queryByText('Feed generation failed')).not.toBeInTheDocument();
+    expect(window.sessionStorage.getItem('html2rss_access_token')).toBeNull();
+  });
 });

frontend/src/__tests__/useFeedConversion.contract.test.ts

@@ -60,4 +60,26 @@ describe('useFeedConversion contract', () => {
     expect(result.current.result).toBeNull();
     expect(result.current.error).toBe('URL parameter is required');
   });
+
+  it('normalizes malformed successful responses', async () => {
+    server.use(
+      http.post('/api/v1/feeds', async () =>
+        HttpResponse.text('not-json', {
+          status: 200,
+          headers: { 'content-type': 'application/json' },
+        })
+      )
+    );
+
+    const { result } = renderHook(() => useFeedConversion());
+
+    await act(async () => {
+      await expect(
+        result.current.convertFeed('https://example.com/articles', 'ssrf_filter', 'token')
+      ).rejects.toThrow('Invalid response format from feed creation API');
+    });
+
+    expect(result.current.result).toBeNull();
+    expect(result.current.error).toBe('Invalid response format from feed creation API');
+  });
 });

frontend/src/hooks/useFeedConversion.ts

@@ -85,6 +85,7 @@ export function useFeedConversion() {
 }
 
 const toErrorMessage = (error: unknown): string => {
+  if (error instanceof SyntaxError) return 'Invalid response format from feed creation API';
   if (error instanceof Error) return error.message;
   if (typeof error === 'string' && error.trim()) return error;
 

frontend/src/styles/main.css

@@ -627,8 +627,11 @@ a:focus-visible {
 .result-actions--quiet {
   width: min(100%, 40rem);
   margin: 0 auto;
+  display: flex;
+  flex-wrap: nowrap;
+  align-items: center;
   justify-items: start;
-  justify-content: start;
+  justify-content: flex-start;
   gap: var(--space-4);
   margin-top: calc(var(--space-2) * -1);
 }
@@ -697,7 +700,7 @@ a:focus-visible {
   }
 
   .result-actions {
-    grid-template-columns: repeat(2, minmax(0, auto));
+    grid-template-columns: none;
   }
 
   .utility-strip__items {
@@ -727,6 +730,7 @@ a:focus-visible {
   }
 
   .result-actions--quiet {
+    display: grid;
     grid-template-columns: 1fr;
     gap: var(--space-3);
   }