Skip to content

Commit 392997c

Browse files
committed
fix: harden container config defaults
1 parent 424b890 commit 392997c

3 files changed

Lines changed: 7 additions & 11 deletions

File tree

.devcontainer/devcontainer.json

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,15 +8,11 @@
88
"vscode": {
99
"extensions": [
1010
"rebornix.ruby",
11-
"astro-build.astro-vscode",
1211
"esbenp.prettier-vscode"
1312
],
1413
"settings": {
1514
"editor.formatOnSave": true,
1615
"editor.defaultFormatter": "esbenp.prettier-vscode",
17-
"files.associations": {
18-
"*.astro": "astro"
19-
},
2016
"prettier.configPath": "./frontend/prettier.config.js",
2117
"ruby.format": "rubocop",
2218
"ruby.lint": { "rubocop": true },
@@ -34,7 +30,7 @@
3430
"onAutoForward": "notify"
3531
},
3632
"4001": {
37-
"label": "Astro Dev Server",
33+
"label": "Vite Dev Server",
3834
"onAutoForward": "silent"
3935
}
4036
},

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ curl -X POST "https://your-domain.com/api/v1/feeds" \
4141
## Deploy (Docker Compose)
4242

4343
1. Generate a key: `openssl rand -hex 32`.
44-
2. Set `HTML2RSS_SECRET_KEY` in `docker-compose.yml`.
44+
2. Export `HTML2RSS_SECRET_KEY`, `HEALTH_CHECK_TOKEN`, and `BROWSERLESS_IO_API_TOKEN` in your shell or `.env`.
4545
3. Start: `docker-compose up`.
4646

4747
UI + API run on `http://localhost:4000`. The app exits if the secret key is missing.

docker-compose.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -15,17 +15,17 @@ services:
1515
environment:
1616
RACK_ENV: production
1717
PORT: 4000
18-
HTML2RSS_SECRET_KEY: your-generated-secret-key-here
19-
HEALTH_CHECK_TOKEN: CHANGE_ME_HEALTH_CHECK_TOKEN
18+
HTML2RSS_SECRET_KEY: ${HTML2RSS_SECRET_KEY:?set HTML2RSS_SECRET_KEY}
19+
HEALTH_CHECK_TOKEN: ${HEALTH_CHECK_TOKEN:?set HEALTH_CHECK_TOKEN}
2020
BROWSERLESS_IO_WEBSOCKET_URL: ws://browserless:4002
21-
BROWSERLESS_IO_API_TOKEN: 6R0W53R135510
21+
BROWSERLESS_IO_API_TOKEN: ${BROWSERLESS_IO_API_TOKEN:?set BROWSERLESS_IO_API_TOKEN}
2222

2323
watchtower:
2424
image: containrrr/watchtower
2525
restart: unless-stopped
2626
volumes:
2727
- /var/run/docker.sock:/var/run/docker.sock
28-
- "~/.docker/config.json:/config.json"
28+
- "${HOME}/.docker/config.json:/config.json"
2929
command: --cleanup --interval 7200
3030

3131
browserless:
@@ -36,4 +36,4 @@ services:
3636
environment:
3737
PORT: 4002
3838
CONCURRENT: 10
39-
TOKEN: 6R0W53R135510
39+
TOKEN: ${BROWSERLESS_IO_API_TOKEN:?set BROWSERLESS_IO_API_TOKEN}

0 commit comments

Comments
 (0)