fix(smoke): make docker probes runnable in real container environments

Stabilize docker smoke validation by allowing localhost traffic outside VCR cassettes and by adapting feed-creation assertions to the auto-source feature toggle.

Decision: treat AUTO_SOURCE as environment-driven in smoke expectations so deployments with feature disabled still verify health/auth behavior without false negatives.

This preserves strict VCR behavior for non-local traffic while restoring actionable smoke feedback for production-like checks.

Author: gildesmarais

spec/smoke/docker_spec.rb

@@ -8,6 +8,9 @@
   let(:base_url) { ENV.fetch('SMOKE_BASE_URL', 'http://127.0.0.1:4000') }
   let(:health_token) { ENV.fetch('SMOKE_HEALTH_TOKEN', 'health-check-token-xyz789') }
   let(:feed_token) { ENV.fetch('SMOKE_API_TOKEN', 'allow-any-urls-abcd-4321') }
+  let(:auto_source_enabled) do
+    ENV.fetch('SMOKE_AUTO_SOURCE_ENABLED', ENV.fetch('AUTO_SOURCE_ENABLED', 'false')) == 'true'
+  end
 
   def get_json(path, headers: {})
     uri = URI.join(base_url, path)
@@ -54,8 +57,15 @@ def perform_request(uri, request)
     }
 
     response, body = post_json('/api/v1/feeds', body: payload)
-    expect(response).to be_a(Net::HTTPUnauthorized)
-    expect(body.dig('error', 'code')).to eq('UNAUTHORIZED')
+    if auto_source_enabled
+      expect(response).to be_a(Net::HTTPUnauthorized)
+      expect(body.dig('error', 'code')).to eq('UNAUTHORIZED')
+    else
+      expect(response).to be_a(Net::HTTPForbidden)
+      expect(body.dig('error', 'code')).to eq('FORBIDDEN')
+      expect(body.dig('error', 'message')).to eq('Auto source feature is disabled')
+      next
+    end
 
     response, body = post_json('/api/v1/feeds',
                                body: payload,

spec/spec_helper.rb

@@ -24,6 +24,7 @@
 VCR.configure do |config|
   config.cassette_library_dir = 'spec/fixtures/vcr_cassettes'
   config.hook_into :faraday, :webmock
+  config.ignore_localhost = true
 end
 
 Dir[File.join(__dir__, 'support/**/*.rb')].each { |support_file| require support_file }