refactor(observability): normalize request context field naming in middleware

Author: gildesmarais

app/account_manager.rb

@@ -72,7 +72,7 @@ def mutex
         def build_snapshot
           raw_accounts = LocalConfig.global.dig(:auth, :accounts)
           accounts = Array(raw_accounts).map { |account| account.transform_keys(&:to_sym).freeze }.freeze
-          token_index = accounts.each_with_object({}) { |account, hash| hash[account[:token]] = account }.freeze
+          token_index = accounts.to_h { |account| [account[:token], account] }.freeze
 
           SecurityLogger.log_cache_lifecycle('account_manager', 'build', accounts_count: accounts.length)
           { accounts: accounts, token_index: token_index }.freeze

app/request_context.rb

@@ -7,7 +7,7 @@ module Web
     module RequestContext
       ##
       # Immutable request context model.
-      Context = Data.define(:request_id, :path, :method, :route_group, :actor, :strategy, :started_at)
+      Context = Data.define(:request_id, :path, :http_method, :route_group, :actor, :strategy, :started_at)
 
       class << self
         # @param context [Context]
@@ -41,7 +41,7 @@ def context_hash(context)
           {
             request_id: context.request_id,
             path: context.path,
-            method: context.method,
+            method: context.http_method,
             route_group: context.route_group,
             actor: context.actor,
             strategy: context.strategy,

app/request_context_middleware.rb

@@ -60,7 +60,7 @@ def build_context(request)
         RequestContext::Context.new(
           request_id: request_id_for(request),
           path: path,
-          method: request.request_method.to_s.upcase,
+          http_method: request.request_method.to_s.upcase,
           route_group: route_group_for(path),
           actor: nil,
           strategy: request.params['strategy'],

spec/html2rss/web/request_context_middleware_spec.rb

@@ -23,7 +23,7 @@
   def middleware_app
     app = lambda do |_env|
       context = Html2rss::Web::RequestContext.current
-      [200, { 'Content-Type' => 'text/plain' }, ["#{context.route_group}:#{context.method}"]]
+      [200, { 'Content-Type' => 'text/plain' }, ["#{context.route_group}:#{context.http_method}"]]
     end
     described_class.new(app)
   end

spec/spec_helper.rb

@@ -50,6 +50,7 @@
     # Only reset if SecurityLogger is defined (loaded)
     Html2rss::Web::SecurityLogger.reset_logger! if defined?(Html2rss::Web::SecurityLogger)
     Html2rss::Web::AccountManager.reload! if defined?(Html2rss::Web::AccountManager)
+    Html2rss::Web::LocalConfig.reload! if defined?(Html2rss::Web::LocalConfig)
   end
 
   # rspec-expectations config goes here. You can use an alternate