Skip to content

Commit 7a18e30

Browse files
committed
ci: address release review findings
1 parent f80963d commit 7a18e30

2 files changed

Lines changed: 2 additions & 22 deletions

File tree

.github/workflows/release.yml

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -122,26 +122,6 @@ jobs:
122122
ref: ${{ needs.guard.outputs.target_sha }}
123123
fetch-depth: 0
124124

125-
- name: Setup pnpm
126-
uses: pnpm/action-setup@v6
127-
with:
128-
cache: true
129-
cache_dependency_path: frontend/pnpm-lock.yaml
130-
package_json_file: frontend/package.json
131-
132-
- name: Setup Node.js for Docker build
133-
uses: actions/setup-node@v6
134-
with:
135-
node-version-file: ".tool-versions"
136-
137-
- name: Install frontend dependencies
138-
run: pnpm install --frozen-lockfile
139-
working-directory: frontend
140-
141-
- name: Build frontend static assets
142-
run: pnpm run build
143-
working-directory: frontend
144-
145125
- name: Set up QEMU
146126
uses: docker/setup-qemu-action@v4
147127

Dockerfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,8 +45,8 @@ LABEL maintainer="Gil Desmarais <html2rss-web-docker@desmarais.de>"
4545

4646
SHELL ["/bin/ash", "-o", "pipefail", "-c"]
4747

48-
ARG BUILD_TAG=unknown
49-
ARG GIT_SHA=unknown
48+
ARG BUILD_TAG
49+
ARG GIT_SHA
5050

5151
ENV PORT=4000 \
5252
RACK_ENV=production \

0 commit comments

Comments
 (0)