Keep API error contracts in development

Author: gildesmarais

app.rb

@@ -92,7 +92,7 @@ def development? = self.class.development?
       plugin :not_allowed
       plugin :exception_page
       plugin :error_handler do |error|
-        next exception_page(error) if development? && !error.is_a?(NotFoundError)
+        next exception_page(error) if development? && !error.is_a?(HttpError)
 
         ErrorResponder.respond(request: request, response: response, error: error)
       end

spec/html2rss/web/app_spec.rb

@@ -216,6 +216,19 @@ def app = described_class
       expect(json.dig('error', 'code')).to eq(Html2rss::Web::InternalServerError::CODE)
       expect(json.dig('error', 'message')).to eq('Internal Server Error')
     end
+
+    it 'keeps API auth failures on the JSON error contract in development mode' do
+      ClimateControl.modify('RACK_ENV' => 'development') do
+        post '/api/v1/feeds', JSON.generate(url: 'https://example.com/articles'),
+             { 'CONTENT_TYPE' => 'application/json', 'HTTP_AUTHORIZATION' => 'Bearer invalid-token' }
+      end
+
+      expect(last_response.status).to eq(401)
+      expect(last_response.headers['Content-Type']).to include('application/json')
+      json = JSON.parse(last_response.body)
+      expect(json.dig('error', 'code')).to eq(Html2rss::Web::UnauthorizedError::CODE)
+      expect(json.dig('error', 'message')).to eq('Authentication required')
+    end
   end
 
   describe '.development?' do