Refactor spec doubles for Html2rss feeds

Author: gildesmarais

spec/html2rss/web/api/v1_spec.rb

@@ -64,6 +64,11 @@ def app = Html2rss::Web::App.freeze.app
   end
 
   describe 'GET /api/v1/feeds/:token' do
+    before do
+      stub_const('Html2rss::FeedChannel', Class.new { attr_reader :ttl })
+      stub_const('Html2rss::Feed', Class.new { attr_reader :channel })
+    end
+
     it 'returns unauthorized when account not found', :aggregate_failures do # rubocop:disable RSpec/ExampleLength
       ghost_token = Html2rss::Web::FeedToken
                     .create_with_validation(
@@ -87,7 +92,9 @@ def app = Html2rss::Web::App.freeze.app
       token = Html2rss::Web::Auth.generate_feed_token('admin', feed_url, strategy: 'ssrf_filter')
 
       allow(Html2rss::Web::AutoSource).to receive(:generate_feed_object)
-        .and_return(instance_double('Html2rss::Feed', channel: instance_double('Html2rss::FeedChannel', ttl: 10)))
+        .and_return(
+          instance_double(Html2rss::Feed, channel: instance_double(Html2rss::FeedChannel, ttl: 10))
+        )
       allow(Html2rss::Web::FeedGenerator).to receive(:process_feed_content)
         .and_return('<rss version="2.0"></rss>')
 

spec/html2rss/web/app_integration_spec.rb

@@ -35,19 +35,27 @@
 
   before do
     allow(Html2rss::Web::LocalConfig).to receive(:yaml).and_return(accounts_config)
-    token_payload = instance_double(Html2rss::Web::FeedToken, url: feed_url, username: account[:username],
-                                                           strategy: 'ssrf_filter')
+    stub_const('Html2rss::FeedChannel', Class.new { attr_reader :ttl })
+    stub_const('Html2rss::Feed', Class.new { attr_reader :channel })
+    token_payload = instance_double(
+      Html2rss::Web::FeedToken,
+      url: feed_url,
+      username: account[:username],
+      strategy: 'ssrf_filter'
+    )
     allow(Html2rss::Web::FeedToken).to receive_messages(
       decode: token_payload,
       validate_and_decode: token_payload
     )
     allow(Html2rss::Web::AccountManager).to receive(:get_account_by_username).and_return(account)
     allow(Html2rss::Web::UrlValidator).to receive(:url_allowed?).and_return(true)
-    feed_channel = instance_double('Html2rss::FeedChannel', ttl: 10)
-    feed_object = instance_double('Html2rss::Feed', channel: feed_channel)
+    feed_channel = instance_double(Html2rss::FeedChannel, ttl: 10)
+    feed_object = instance_double(Html2rss::Feed, channel: feed_channel)
 
-    allow(Html2rss::Web::AutoSource).to receive(:enabled?).and_return(true)
-    allow(Html2rss::Web::AutoSource).to receive(:generate_feed_object).and_return(feed_object)
+    allow(Html2rss::Web::AutoSource).to receive_messages(
+      enabled?: true,
+      generate_feed_object: feed_object
+    )
     allow(Html2rss::Web::FeedGenerator).to receive(:process_feed_content)
       .and_return('<rss version="2.0"></rss>')
   end