fix PR review findings for status contract and storage utils

Author: gildesmarais

…src/__tests__/feedSessionStorage.test.ts …rc/__tests__/feedWorkflowStorage.test.tsfrontend/src/__tests__/feedSessionStorage.test.ts renamed to frontend/src/__tests__/feedWorkflowStorage.test.ts frontend/src/__tests__/feedSessionStorage.test.ts renamed to frontend/src/__tests__/feedWorkflowStorage.test.ts

@@ -7,9 +7,9 @@ import {
   loadFeedResultState,
   saveFeedDraftState,
   saveFeedResultSnapshot,
-} from '../utils/feedSessionStorage';
+} from '../utils/feedWorkflowStorage';
 
-describe('feedSessionStorage', () => {
+describe('feedWorkflowStorage', () => {
   beforeEach(() => {
     globalThis.localStorage.clear();
     globalThis.sessionStorage.clear();

frontend/src/api/generated/sdk.gen.ts

@@ -52,7 +52,7 @@ export const renderFeedByToken = <ThrowOnError extends boolean = false>(options:
  *
  * Get feed status
  */
-export const getFeedStatus = <ThrowOnError extends boolean = false>(options?: Options<GetFeedStatusData, ThrowOnError>) => (options?.client ?? client).get<GetFeedStatusResponses, unknown, ThrowOnError>({ url: '/feeds/{token}/status', ...options });
+export const getFeedStatus = <ThrowOnError extends boolean = false>(options: Options<GetFeedStatusData, ThrowOnError>) => (options.client ?? client).get<GetFeedStatusResponses, unknown, ThrowOnError>({ url: '/feeds/{token}/status', ...options });
 
 /**
  * Authenticated health check

frontend/src/api/generated/types.gen.ts

@@ -153,7 +153,9 @@ export type RenderFeedByTokenResponse = RenderFeedByTokenResponses[keyof RenderF
 
 export type GetFeedStatusData = {
     body?: never;
-    path?: never;
+    path: {
+        token: string;
+    };
     query?: never;
     url: '/feeds/{token}/status';
 };

frontend/src/components/App.tsx

@@ -11,7 +11,7 @@ import {
   loadFeedDraftState,
   loadFeedResultState,
   saveFeedDraftState,
-} from '../utils/feedSessionStorage';
+} from '../utils/feedWorkflowStorage';
 import { normalizeUserUrl } from '../utils/url';
 import type { WorkflowState } from './AppPanels';
 import type { CreatedFeedResult, FeedCreationError } from '../api/contracts';

frontend/src/hooks/useFeedConversion.ts

@@ -12,7 +12,7 @@ import type {
   FeedRetryState,
   FeedStatusWarning,
 } from '../api/contracts';
-import { saveFeedResultSnapshot } from '../utils/feedSessionStorage';
+import { saveFeedResultSnapshot } from '../utils/feedWorkflowStorage';
 import { normalizeUserUrl } from '../utils/url';
 
 interface ConversionState {

frontend/src/utils/feedSessionStorage.ts frontend/src/utils/feedWorkflowStorage.tsfrontend/src/utils/feedSessionStorage.ts renamed to frontend/src/utils/feedWorkflowStorage.ts

@@ -6,8 +6,12 @@ const memoryStorage = (() => {
       return store.size;
     },
     clear: () => store.clear(),
-    getItem: (key: string) => store.get(key),
-    key: (index: number) => [...store.keys()][index],
+    // Storage#getItem returns null when a key is missing.
+    // eslint-disable-next-line unicorn/no-null
+    getItem: (key: string) => store.get(key) ?? null,
+    // Storage#key returns null when the index is out of range.
+    // eslint-disable-next-line unicorn/no-null
+    key: (index: number) => [...store.keys()][index] ?? null,
     removeItem: (key: string) => {
       store.delete(key);
     },

frontend/src/utils/persistentStorage.ts

@@ -318,6 +318,12 @@ paths:
     get:
       description: Get feed status
       operationId: getFeedStatus
+      parameters:
+      - in: path
+        name: token
+        required: true
+        schema:
+          type: string
       responses:
         '200':
           content:

public/openapi.yaml

@@ -451,11 +451,19 @@ def expected_featured_feeds
       )
     end
 
-    describe 'GET /api/v1/feeds/{token}/status', openapi: {
+    describe 'GET /api/v1/feeds/:token/status', openapi: {
       summary: 'Get feed status',
       description: 'Returns readiness and degradation metadata for a generated feed.',
       operation_id: 'getFeedStatus',
       tags: ['Feeds'],
+      parameters: [
+        {
+          name: :token,
+          in: :path,
+          required: true,
+          schema: { type: :string }
+        }
+      ],
       security: []
     } do
       it 'documents structured feed status for ready feeds', :aggregate_failures do

spec/html2rss/web/api/v1_spec.rb

@@ -35,6 +35,7 @@ def expect_error_response(response, code:, **expected)
   def expect_feed_payload(json)
     feed = json.fetch('data').fetch('feed')
     expect_feed_identifier_payload(feed)
+    expect_feed_source_payload(feed)
     expect(feed).not_to have_key('strategy')
     feed
   end