Skip to content

Commit 2cac3db

Browse files
committed
fixes to address pr comments
1 parent cb422cd commit 2cac3db

4 files changed

Lines changed: 13 additions & 13 deletions

File tree

payload-gen-rna-alignment/main.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@
4545
data_type_mapping = {
4646
#file_type: [dataCategory, dataType, [data_subtypes], [star analysis_tools], [hisat2 analysis_tools]]
4747
'genome_aln': ['Sequencing Reads', 'Aligned Reads', ['Genome Alignment'], ['STAR'], ['HiSAT2']],
48-
'transcriptome_aln': ['Sequencing Reads', 'Aligned Reads', ['transcriptome Alignment'], ['STAR'], ['HiSAT2']],
48+
'transcriptome_aln': ['Sequencing Reads', 'Aligned Reads', ['Transcriptome Alignment'], ['STAR'], ['HiSAT2']],
4949
'chimeric_aln': ['Sequencing Reads', 'Aligned Reads', ['Chimeric Alignment'], ['STAR'], ['HiSAT2']],
5050
'splice_junctions': ['Transcriptome Profiling', 'Splice Junctions', [None], ['STAR'], ['HiSAT2']],
5151
'fastqc': ['Quality Control Metrics', 'Sequencing QC', ['Read Group Metrics'], ['FastQC'], ['FastQC']],
@@ -285,8 +285,8 @@ def main():
285285
parser.add_argument("-b", "--genome_build", dest="genome_build", default="GRCh38_hla_decoy_ebv", help="RNA-Seq alignment genome build")
286286
parser.add_argument("-w", "--wf_name", dest="wf_name", required=True, help="Workflow name")
287287
parser.add_argument("-v", "--wf_version", dest="wf_version", required=True, help="Workflow version")
288-
parser.add_argument("-r", "--wf_run", dest="wf_run", required=True, help="workflow run ID")
289-
parser.add_argument("-s", "--wf_session", dest="wf_session", required=True, help="workflow session ID")
288+
parser.add_argument("-r", "--wf_run", dest="wf_run", required=True, help="Workflow run ID")
289+
parser.add_argument("-s", "--wf_session", dest="wf_session", required=True, help="Workflow session ID")
290290
args = parser.parse_args()
291291

292292
with open(args.seq_experiment_analysis, 'r') as f:

payload-gen-rna-alignment/tests/expected/expected.test-job-1.out.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,8 @@
88
"workflow_version": "0.1.0",
99
"genome_build": "GRCh38_hla_decoy_ebv",
1010
"genome_annotation": "GENCODE v38",
11-
"run_id": "exotic_darwin",
12-
"session_id": "1c2b7b63-3b5f-40e2-a6b2-3dcd9d71217c",
11+
"run_id": "insane_hugle",
12+
"session_id": "67ccf9ba-915e-4dda-ac5c-975fd1ff0509",
1313
"inputs": [
1414
{
1515
"analysis_type": "sequencing_experiment",
@@ -71,7 +71,7 @@
7171
"experiment": {
7272
"submitter_sequencing_experiment_id": "TEST_EXP",
7373
"sequencing_center": "SIM",
74-
"platform": "Simulation",
74+
"platform": "ILLUMINA",
7575
"platform_model": "Polyester",
7676
"experimental_strategy": "RNA-Seq",
7777
"sequencing_date": "2021-04-21"

payload-gen-rna-alignment/tests/expected/expected.test-job-2.out.json

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,8 @@
88
"workflow_version": "0.1.0",
99
"genome_build": "GRCh38_hla_decoy_ebv",
1010
"genome_annotation": "GENCODE v38",
11-
"run_id": "amazing_keller",
12-
"session_id": "e281fe1b-8b46-4b77-a1f1-349ad53b76e3",
11+
"run_id": "ridiculous_bhaskara",
12+
"session_id": "b2c42a90-fb78-4ba3-8a02-0bb02dfbf309",
1313
"inputs": [
1414
{
1515
"analysis_type": "sequencing_experiment",
@@ -64,7 +64,7 @@
6464
},
6565
"description": "RNA alignment metrics for a SAM or BAM file."
6666
},
67-
"fileName": "TEST-PRO.DO001.SA001.rna-seq.20211014.star.collectrnaseqmetrics.tgz",
67+
"fileName": "TEST-PRO.DO001.SA001.rna-seq.20211109.star.collectrnaseqmetrics.tgz",
6868
"dataType": "Aligned Reads QC"
6969
},
7070
{
@@ -98,7 +98,7 @@
9898
]
9999
}
100100
},
101-
"fileName": "TEST-PRO.DO001.SA001.rna-seq.20211014.star.duplicates_metrics.tgz",
101+
"fileName": "TEST-PRO.DO001.SA001.rna-seq.20211109.star.duplicates_metrics.tgz",
102102
"dataType": "Aligned Reads QC"
103103
},
104104
{
@@ -132,7 +132,7 @@
132132
},
133133
"description": "High level sequencing reads QC metrics generated by FastQC."
134134
},
135-
"fileName": "TEST-PRO.DO001.SA001.rna-seq.20211014.S01L1.fastqc.tgz",
135+
"fileName": "TEST-PRO.DO001.SA001.rna-seq.20211109.S01L1.fastqc.tgz",
136136
"dataType": "Sequencing QC"
137137
}
138138
],
@@ -156,7 +156,7 @@
156156
"experiment": {
157157
"submitter_sequencing_experiment_id": "TEST_EXP",
158158
"sequencing_center": "SIM",
159-
"platform": "Simulation",
159+
"platform": "ILLUMINA",
160160
"platform_model": "Polyester",
161161
"experimental_strategy": "RNA-Seq",
162162
"sequencing_date": "2021-04-21"

tests/data/s3.881fe6cf-8c80-4c7b-9f4d-b8dac9601d01.sequencing_experiment.payload.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
"experiment": {
77
"submitter_sequencing_experiment_id": "TEST_EXP",
88
"sequencing_center": "SIM",
9-
"platform": "Simulation",
9+
"platform": "ILLUMINA",
1010
"platform_model": "Polyester",
1111
"experimental_strategy": "RNA-Seq",
1212
"sequencing_date": "2021-04-21"

0 commit comments

Comments
 (0)