Fix type errors

Author: znorman-harris

libs/parsing/index/src/lib/global-index.class.ts

@@ -56,7 +56,7 @@ export class GlobalIndex {
   /**
    * Tokens categorized by type to reduce number of checks for global conflicts
    */
-  globalTokensByTypeByName: GlobalTokensByTypeByName = {};
+  globalTokensByTypeByName!: GlobalTokensByTypeByName;
 
   /**
    * Constructor which initializes properties in our constants so that they
@@ -111,7 +111,7 @@ export class GlobalIndex {
         const byNameForType = this.globalTokensByTypeByName[types[i]];
         const names = Object.keys(byNameForType);
         for (let j = 0; j < names.length; j++) {
-          exported[types[i]].push(byNameForType[names[j]][0]);
+          exported[types[i]].push(byNameForType[names[j]][0] as any);
         }
       }
       return exported;
@@ -332,7 +332,9 @@ export class GlobalIndex {
                 break;
               case byName.length === 1:
                 // remove display name
-                delete IDL_DISPLAY_NAMES[tokens[i].type][tokens[i].name];
+                delete (IDL_DISPLAY_NAMES[tokens[i].type] || {})[
+                  tokens[i].name
+                ];
 
                 // remove structure/type names
                 if (tokens[i].type === GLOBAL_TOKEN_TYPES.STRUCTURE) {
@@ -355,7 +357,7 @@ export class GlobalIndex {
 
       // mark as changed if we had problems
       if (file in this.globalSyntaxProblemsByFile) {
-        this.changedFiles[file] = undefined;
+        this.changedFiles[file] = false;
       }
 
       // reset problems for our file as well
@@ -456,9 +458,11 @@ export class GlobalIndex {
 
       // save by type
       if (token.name in this.globalTokensByTypeByName[token.type]) {
-        this.globalTokensByTypeByName[token.type][token.name].push(token);
+        this.globalTokensByTypeByName[token.type][token.name].push(
+          token as any,
+        );
       } else {
-        this.globalTokensByTypeByName[token.type][token.name] = [token];
+        this.globalTokensByTypeByName[token.type][token.name] = [token as any];
       }
     }
   }
@@ -558,8 +562,8 @@ export class GlobalIndex {
 
     // check all files that we need to process
     const files = this.globalTokensByTypeByName[token.type][token.name]
-      .filter((item) => item.file !== undefined)
-      .map((item) => item.file);
+      .map((item) => item.file)
+      .filter((item) => item !== undefined);
 
     // process each file
     for (let z = 0; z < files.length; z++) {
@@ -577,6 +581,11 @@ export class GlobalIndex {
         // extract the problem
         const problem = problems[j];
 
+        // skip if no file
+        if (!problem.file) {
+          continue;
+        }
+
         // check if our file matches
         if (
           (problem.file === token.file || clear) &&

libs/parsing/index/src/lib/global-index.interface.ts

@@ -22,9 +22,9 @@ export type GlobalIndexedToken = IGlobalIndexedToken<GlobalTokenType>;
  * Lookup with all tokens by type. We store an array of the token types
  * which we can manually search through to find.
  */
-export interface GlobalTokensByTypeByName {
-  [key: string]: { [key: string]: GlobalIndexedToken[] };
-}
+export type GlobalTokensByTypeByName = {
+  [key in GlobalTokenType]: { [name: string]: IGlobalIndexedToken<key>[] };
+};
 
 /**
  * Lookup with tokens by type for easier access when we export
@@ -33,14 +33,14 @@ export type ExportedGlobalTokensByType = {
   [key in GlobalTokenType]: IGlobalIndexedToken<key>[];
 };
 
-/**
- * For each file we index tokens for, track which types of tokens they
- * contribute to filter the locations we need to clean up tokens from so
- * we don't need to process all tokens.
- */
-export interface ITokenTypesByFile {
-  [file: string]: { [key: string]: GlobalIndexedToken[] };
-}
+// /**
+//  * For each file we index tokens for, track which types of tokens they
+//  * contribute to filter the locations we need to clean up tokens from so
+//  * we don't need to process all tokens.
+//  */
+// export type ITokenTypesByFile = {
+//   [file: string]: { [key in GlobalTokenType]: GlobalIndexedToken[] };
+// };
 
 /**
  * Maps our token types to problem codes

libs/types/idl-data-types/src/lib/global-types.interface.ts

@@ -48,15 +48,15 @@ interface IGlobalTokenTypeLookup {
 /**
  * Names for all global tokens
  */
-export const GLOBAL_TOKEN_TYPES: IGlobalTokenTypeLookup = {
+export const GLOBAL_TOKEN_TYPES = {
   FUNCTION: 'f',
   PROCEDURE: 'p',
   FUNCTION_METHOD: 'fm',
   PROCEDURE_METHOD: 'pm',
   STRUCTURE: 's',
   SYSTEM_VARIABLE: 'sv',
   COMMON: 'c',
-};
+} as const satisfies IGlobalTokenTypeLookup;
 
 /** Native code */
 type InternalTokenSource = 'internal';