Skip to content

Commit 2f3a3f7

Browse files
Change kernel label to include IDL version after we start
1 parent af68fa7 commit 2f3a3f7

2 files changed

Lines changed: 7 additions & 7 deletions

File tree

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,8 @@ When IDL starts up for notebooks, we now check to make sure you have at least ID
5454

5555
Updated the main README and notebooks docs to reflect the version requirements.
5656

57+
When IDL starts for Notebooks, we update the kernel indicator in the top-right of the notebook to show the version of IDL we are using. We use this now instead of the pop-up window that used to appear.
58+
5759
## 4.4.1 April 2024
5860

5961
Fix a bug where watch variables were being executed and causing chaos in IDL debug sessions

libs/vscode/notebooks/src/lib/controller/idl-notebook-controller.class.ts

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -608,13 +608,8 @@ export class IDLNotebookController {
608608
return;
609609
}
610610

611-
// alert user we have started IDL for their notebook
612-
vscode.window.showInformationMessage(
613-
IDL_TRANSLATION.notebooks.notifications.startedIDLKernel.replace(
614-
'{VERSION}',
615-
parsed.release
616-
)
617-
);
611+
// update kernel text
612+
this._controller.label = `IDL ${parsed.release}`;
618613

619614
// send usage metric
620615
VSCodeTelemetryLogger(USAGE_METRIC_LOOKUP.IDL_STARTUP, {
@@ -1038,6 +1033,9 @@ export class IDLNotebookController {
10381033
// reset decorations
10391034
IDL_DECORATIONS_MANAGER.reset('notebook');
10401035

1036+
// reset the label
1037+
this._controller.label = `IDL`;
1038+
10411039
// stop IDL if we can
10421040
if (this.isStarted()) {
10431041
this._runtime.stop();

0 commit comments

Comments
 (0)